-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(monorepo): prefix output with package name #1378
Conversation
https://github.com/ipfs/aegir/actions/runs/6425141074/job/17447167829#step:5:19 |
I've opened bbc/typescript-docs-verifier#30 Quick fix: #1380 |
9a17403
to
2d0a917
Compare
This looks interesting, it should probably default to prefixing scripts run in monorepo projects and not prefixing tasks run in regular projects? It could use some tests to verify this too. |
Ah, so |
Not sure that a test is needed for this. |
@achingbrain ready for re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I added some tests because I got bored of testing things manually like an animal - it looks like the output for aegir run
is getting double-prefixed. It may be something to do with the child process inheriting stdin/out, needs a bit of investigation.
Relevant: sindresorhus/execa#121 |
I stole the way lerna does it, using strong-long-transformer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This fails on my local machine
|
Hmm, weird that it works in CI? |
It seems that the Maybe we can add a package dependency in the monorepo test fixture to ensure the ordering. |
ready for re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
## [41.2.0](v41.1.14...v41.2.0) (2023-12-12) ### Features * **monorepo:** prefix output with package name ([#1378](#1378)) ([5ffac14](5ffac14))
In the monorepo commands (
exec
,releaseRc
, andrun
), prefix each line of output from each subpackage with the name of the package where the command is running.This can be disabled by providing the
--noPrefix
cli arg.