Chore/update examples #347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit does two things. Firstly the correct file path to transcompiled js file is /dist/index.js not /dist/src/index.js. Secondly for the example to run npm test needs to be called first in order to build into the correct directory. Although this is somewhat non-standard with the rest of helia-examples following some npm install then npm start as the convention. However I did not want to disrupt the rest of the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went through a ran
npm outdatedandnpx npm-check-updateson each example to find outdated dependencies and also update to the newest versionSpecifically modified the Typescript example. It was the only example that did not smoothly run by simply following Installation/Running example/Usage guide.