[actpool] Simplify action store #4515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envestcc
requested review from
CoderZhi,
dustinxie and
Liuhaai
as code owners
|
CoderZhi
approved these changes
Dec 6, 2024
dustinxie
reviewed
Jan 6, 2025
| @@ -56,7 +55,6 @@ type ( | |||
| } | |||
| actionStoreConfig struct { | |||
| Datadir string `yaml:"datadir"` // Data directory containing the currently executable blobs | |||
| Datacap uint64 `yaml:"datacap"` // Soft-cap of database storage (hard cap is larger due to overhead) | |||
There was a problem hiding this comment.
for v2.1.0 release, we added this config into config.yaml. AFAI recall, datacap is not added in the yaml file, but please make sure, so that existing full-node can start normally with existing yaml file
There was a problem hiding this comment.
yes, it has not been written in the config
dustinxie
reviewed
Jan 6, 2025
actpool/actpool.go
Outdated
| @@ -121,8 +119,7 @@ type actPool struct { | |||
| worker []*queueWorker | |||
| subs []Subscriber | |||
|
|
|||
dustinxie
approved these changes
Jan 7, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The persistent capacity limit has been removed to align with the memory pool. This eliminates the need to implement complex eviction mechanisms
Furthermore, because the persistent data is consistent with the memory, there is no longer a need for real-time synchronization during runtime.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: