fix(replay): Make verify_latest_tx_replay_testnet_mainnet test more stable #5014
+37
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
jkrvivian
force-pushed
the
node/test/make-replay-test-stable
branch
3 times, most recently
from
5c1cb6b to
1f22f6b
Compare
jkrvivian
force-pushed
the
node/test/make-replay-test-stable
branch
from
1f22f6b to
09f2d9a
Compare
nmrshll
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Stabilize the
verify_latest_tx_replay_testnet_mainnettest by adding a fallback checkpoint to replay a non-system transaction.The issue is that non-system transactions are rare in the network, causing the test to spend a significant amount of time querying checkpoints (with records of querying over 2200 checkpoints). To address this, a fallback checkpoint containing a known non-system transaction is added. If a non-system transaction cannot be found during iteration, the test will use this fallback checkpoint and replay the transaction.
Links to any relevant issues
Closes #4976
Type of change
Change checklist