Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet): update manage accounts to accomodate for legacy account sources and add legacy badge #5000

Merged
merged 10 commits into from
Jan 24, 2025
Merged

feat(wallet): update manage accounts to accomodate for legacy account sources and add legacy badge #5000

merged 10 commits into from
Jan 24, 2025

Conversation

evavirseda
Copy link
Contributor

@evavirseda evavirseda commented Jan 23, 2025 •
edited
Loading

Description of change

image

Links to any relevant issues

fixes #4810 and #1765

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@evavirseda evavirseda requested a review from a team as a code owner January 23, 2025 16:46
@vercel Vercel
Copy link

vercel bot commented Jan 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2025 3:18pm
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2025 3:18pm
rebased-explorer ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2025 3:18pm
wallet-dashboard ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2025 3:18pm

@evavirseda evavirseda self-assigned this Jan 23, 2025
@github-actions github-actions bot added the wallet Issues related to the IOTA Wallet label Jan 23, 2025
@iota-ci iota-ci added the tooling Issues related to the Tooling team label Jan 23, 2025
@evavirseda evavirseda linked an issue Jan 23, 2025 that may be closed by this pull request
[Task (tooling/wallet)]: Add legacy badge to rotated account bip paths #1765
Closed
@evavirseda evavirseda marked this pull request as draft January 23, 2025 17:10
@vercel vercel bot temporarily deployed to Preview – wallet-dashboard January 23, 2025 17:19 Inactive
@vercel vercel bot temporarily deployed to Preview – rebased-explorer January 23, 2025 17:19 Inactive
@vercel vercel bot temporarily deployed to Preview – apps-backend January 23, 2025 17:19 Inactive
@vercel vercel bot temporarily deployed to Preview – rebased-explorer January 24, 2025 12:02 Inactive
@vercel vercel bot temporarily deployed to Preview – apps-backend January 24, 2025 12:02 Inactive
@evavirseda evavirseda marked this pull request as ready for review January 24, 2025 12:02
@marc2332
Copy link
Contributor

5000 ✨

marc2332
marc2332 approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@marc2332 marc2332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

apps/wallet/src/background/accounts/isLegacyAccount.ts Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – apps-backend January 24, 2025 15:16 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-dashboard January 24, 2025 15:16 Inactive
@vercel vercel bot temporarily deployed to Preview – rebased-explorer January 24, 2025 15:16 Inactive
@begonaalvarezd begonaalvarezd merged commit 324af85 into develop Jan 24, 2025
32 checks passed
@begonaalvarezd begonaalvarezd deleted the tooling-wallet/update-manage-account-to-accomodate-legacy-accounts branch January 24, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc2332 marc2332 marc2332 approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

Assignees

@evavirseda evavirseda

Labels
tooling Issues related to the Tooling team wallet Issues related to the IOTA Wallet
Projects
None yet
Milestone
No milestone
4 participants
@evavirseda @marc2332 @begonaalvarezd @iota-ci