-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix removal of disconnected peers in the peer manager #1182
Merged
thibault-martinez
merged 25 commits into
iotaledger:mainnet-develop
from
Alex6323:mainnet-develop-bee-autopeering-quick-fix-peer-removal
Mar 2, 2022
Merged
Fix removal of disconnected peers in the peer manager #1182
thibault-martinez
merged 25 commits into
iotaledger:mainnet-develop
from
Alex6323:mainnet-develop-bee-autopeering-quick-fix-peer-removal
Mar 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex6323
requested review from
thibault-martinez and
samuel-rufi
as code owners
February 28, 2022 12:32
Alex6323
added
c-bug
Category - Bug
c-enhancement
Category - Enhancement
e-medium
Experience - Medium
n-all
Network - All
p-high
Priority - High
wg-network
Working Group - Network
labels
Feb 28, 2022
thibault-martinez
requested changes
Feb 28, 2022
pvdrz
previously approved these changes
Feb 28, 2022
grtlr
reviewed
Mar 1, 2022
Alex6323
force-pushed
the
mainnet-develop-bee-autopeering-quick-fix-peer-removal
branch
from
March 1, 2022 17:29
ebb9a2f
to
90f81f6
Compare
Adam-Gleave
reviewed
Mar 1, 2022
samuel-rufi
previously approved these changes
Mar 2, 2022
grtlr
previously approved these changes
Mar 2, 2022
Adam-Gleave
previously approved these changes
Mar 2, 2022
thibault-martinez
requested changes
Mar 2, 2022
Co-authored-by: Jochen Görtler <[email protected]>
Alex6323
dismissed stale reviews from Adam-Gleave, grtlr, and samuel-rufi
via
March 2, 2022 12:05
a0502ac
Alex6323
force-pushed
the
mainnet-develop-bee-autopeering-quick-fix-peer-removal
branch
from
March 2, 2022 12:05
90f81f6
to
a0502ac
Compare
thibault-martinez
approved these changes
Mar 2, 2022
grtlr
approved these changes
Mar 2, 2022
Adam-Gleave
approved these changes
Mar 2, 2022
Alex6323
deleted the
mainnet-develop-bee-autopeering-quick-fix-peer-removal
branch
March 2, 2022 13:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c-bug
Category - Bug
e-medium
Experience - Medium
n-all
Network - All
p-high
Priority - High
wg-network
Working Group - Network
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
libp2p
identify protocol;bee-gossip
so that the peer manager inbee-protocol
removes all disconnected peers appropriatedly;Links to any relevant issues
Fixes #1143
Type of change
How the change has been tested
VPS
Change checklist