Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix removal of disconnected peers in the peer manager #1182

Conversation

Alex6323
Copy link
Contributor

@Alex6323 Alex6323 commented Feb 28, 2022

Description of change

  • Improves detection of a valid connection by making use of libp2p identify protocol;
  • Fixes notification of removed peers in bee-gossip so that the peer manager in bee-protocol removes all disconnected peers appropriatedly;
  • Improves logs;

Links to any relevant issues

Fixes #1143

Type of change

  • Enhancement (a non-breaking change which adds functionality)
  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

VPS

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the CHANGELOG.md, if my changes are significant enough

@Alex6323 Alex6323 added c-bug Category - Bug c-enhancement Category - Enhancement e-medium Experience - Medium n-all Network - All p-high Priority - High wg-network Working Group - Network labels Feb 28, 2022
@thibault-martinez thibault-martinez removed the c-enhancement Category - Enhancement label Feb 28, 2022
pvdrz
pvdrz previously approved these changes Feb 28, 2022
@Alex6323 Alex6323 force-pushed the mainnet-develop-bee-autopeering-quick-fix-peer-removal branch from ebb9a2f to 90f81f6 Compare March 1, 2022 17:29
samuel-rufi
samuel-rufi previously approved these changes Mar 2, 2022
grtlr
grtlr previously approved these changes Mar 2, 2022
Adam-Gleave
Adam-Gleave previously approved these changes Mar 2, 2022
bee-network/bee-gossip/src/network/host.rs Show resolved Hide resolved
bee-network/bee-gossip/src/peer/list.rs Show resolved Hide resolved
bee-network/bee-gossip/src/peer/list.rs Show resolved Hide resolved
bee-network/bee-gossip/src/peer/list.rs Outdated Show resolved Hide resolved
bee-network/bee-gossip/src/peer/list.rs Outdated Show resolved Hide resolved
@Alex6323 Alex6323 dismissed stale reviews from Adam-Gleave, grtlr, and samuel-rufi via a0502ac March 2, 2022 12:05
@Alex6323 Alex6323 force-pushed the mainnet-develop-bee-autopeering-quick-fix-peer-removal branch from 90f81f6 to a0502ac Compare March 2, 2022 12:05
@grtlr grtlr added this to the v0.3 milestone Mar 2, 2022
@Alex6323 Alex6323 self-assigned this Mar 2, 2022
@thibault-martinez thibault-martinez merged commit c3f2819 into iotaledger:mainnet-develop Mar 2, 2022
@Alex6323 Alex6323 deleted the mainnet-develop-bee-autopeering-quick-fix-peer-removal branch March 2, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-bug Category - Bug e-medium Experience - Medium n-all Network - All p-high Priority - High wg-network Working Group - Network
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some autopeered peers are kept even if not connected
6 participants