Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streams&refactor #2

Merged
merged 4 commits into from
Apr 15, 2024
Merged

streams&refactor #2

merged 4 commits into from
Apr 15, 2024

Conversation

Okm165
Copy link
Contributor

@Okm165 Okm165 commented Apr 14, 2024

No description provided.

@Okm165 Okm165 requested a review from rkdud007 April 14, 2024 11:24
@Okm165 Okm165 self-assigned this Apr 14, 2024
Copy link
Collaborator

@rkdud007 rkdud007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned on Slack, Two thing to note on:

  1. like appraoch with streams
    But let's have method to expose publish / receive so that can able to test does message sending among delegator and executor node is indeed working fine or not before merge
  1. But personally don't agree with de-abstracting node as both delegator and executor share pretty much same logic to run, just config enum can be different
let node_config = NodeConfig::new(
        NodeType::Delegator,
        Network::Sepolia,
        p2p_local_keypair,
        Vec::new(),
        store,
    );
    let node = Node::new(node_config).await.unwrap();
    ```

Copy link
Collaborator

@rkdud007 rkdud007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rkdud007 rkdud007 merged commit 578577f into main Apr 15, 2024
2 checks passed
@Okm165 Okm165 deleted the streams branch April 19, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants