RMET-3770 ::: Android native library + bridges #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 588f565.
…utsystems-geolocation into feat/RMET-3904/get-location
…utsystems-geolocation into feat/RMET-3904/get-location # Conflicts: # plugin.xml
…o avoid code duplication References: https://outsystemsrd.atlassian.net/browse/RMET-3771
alexgerardojacinto
requested review from
OS-ricardomoreirasilva
and removed request for
OS-ricardomoreirasilva
.../android/src/main/kotlin/com/outsystems/capacitor/plugins/geolocation/OSGeolocationErrors.kt
Outdated
Show resolved
Hide resolved
alexgerardojacinto
force-pushed
the
feat/RMET-3904/get-location
branch
from
d74a72d to
50cdf3d
Compare
OS-ricardomoreirasilva
approved these changes
Jan 3, 2025
…cation # Conflicts: # packages/cordova-plugin/dist/plugin.cjs # packages/cordova-plugin/dist/plugin.js # packages/cordova-plugin/dist/plugin.mjs # packages/cordova-plugin/src/web.ts
ItsChaceD
requested changes
Jan 6, 2025
...in/android/src/main/kotlin/com/outsystems/capacitor/plugins/geolocation/GeolocationPlugin.kt
Show resolved
Hide resolved
…t a single string References: https://outsystemsrd.atlassian.net/browse/RMET-3771
OS-ricardomoreirasilva
approved these changes
Jan 6, 2025
OS-martacarlos
force-pushed
the
feat/RMET-3904/get-location
branch
from
72a4630 to
1ce430b
Compare
ItsChaceD
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
This PR should only be merged after #1. As such, it contains changes that are also present on that PR, that will not appear once that one is merged.
Still missing:
Description
Add Geolocation native Android code to the
android-libpackage. Contains the Kotlin source files and unit tests.Also contains the Android code for the cordova and capacitor plugins, which have the following changes, fixing some issues on behaviours on Android:
Cordova changes
getLocation- renamed togetCurrentPositionmaximumAgein native Android code, used insetMaxUpdateAgeMillis(this one doesn't really make a huge difference as it is being used in Javascript as well).addWatch- renamed towatchPositionmaximumAgenot used asintervalanymore; used as maximum age actually withsetMaxUpdateAgeMillis, andtimeoutis used asinterval.Capacitor changes
getCurrentPositiontimeoutis now used in retrieving the current location (i.e. if no location is retrieved until timeout, an error is returned.watchPositiontimeoutparameter is no passed in theintervalfield (as opposed tosetMaxUpdateDelayMilliswhich mostly just regulated batching), instead of being hardcoded 10 seconds.maximumAgethroughsetMaxUpdateAgeMillisclearWatchType of changes
Platforms affected
Checklist
RNMT-XXXX <title>