This repository has been archived by the owner on Dec 30, 2024. It is now read-only.
Slight improvement to 7af7a8 (bin/chk-entry.sh) #2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using just git use "$GIT_TOOL" as the script already establishes what git to use. The comment I added also explains the rationale about this a bit, as it might not seem immediately clear why it's useful over find(1). And although it was already tested I forced what would have caused a failure before, to happen, so that I could verify that this works as I had originally imagined it: put a file in an entry directory that does not belong there and then run the script again, to make sure it does not detect any problem. Of course with this change one still has to make sure to add valid files to git but that always was how it was anyway.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using just git use "$GIT_TOOL" as the script already establishes what git to use.
The comment I added also explains the rationale about this a bit, as it might not seem immediately clear why it's useful over find(1).
And although it was already tested I forced what would have caused a failure before, to happen, so that I could verify that this works as I had originally imagined it: put a file in an entry directory that does not belong there and then run the script again, to make sure it does not detect any problem.
Of course with this change one still has to make sure to add valid files to git but that always was how it was anyway.