Remove various confusing and apparently out-of-date ignores. #617
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for discussion rather than immediate merging, because probably I'm not right about all of these, but e.g. the ignoring of notebooks in the root directory confused me, so I looked at .gitignore and went down a bit of a rabbit hole...
(listed in order they appear in the diff, just about)
external/*
)?index.rst
plus generated files, i.e. no new human-added files. And I guess you want to ignore generated .rst files (since there's alsoReference_Manual/*-module.rst
in the .gitignore for doc), in which case probably I shouldn't have removed this line.notebooks
directory is no longer used, right? Or I've missed it?_build
to the main .gitignore, removed*.pyc
(redundant), and removed what I think might be out-of-dateReference_Manual/*-module.rst
(might be wrong about that...).Also, you can see things like
include
(line 18) will cause anything calledinclude
to be ignored throughout the repository, whereas e.g./doc/_build
is being explicit about ignoring onlydoc/build
from the root, not from anywhere elsedoc/_build
might appear. Probably worth going through each and deciding which it's supposed to be.