Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Herdsman 2.x.x #2255

Merged
merged 12 commits into from
Oct 25, 2024
Merged

Fixes for Herdsman 2.x.x #2255

merged 12 commits into from
Oct 25, 2024

Conversation

asgothian
Copy link
Collaborator

Fix group member display
Fix group delete
Fix device delete
Fix group member edit
Fix crash on channel scan. Note; Channel scan still defunct, but no longer crashes the adapter

}
}
if (!devStates) {
if (has_debug) this.error(`ELEVATED publishToState: no device states for device ${devId} type '${model}'`)

Check notice

Code scanning / CodeQL

Semicolon insertion Note

Avoid automated semicolon insertion (96% of all statements in
the enclosing function
have an explicit semicolon).
@@ -11,6 +12,7 @@
const DeviceEventExt = require('./zbDeviceEvent');
const DelayedActionExt = require('./zbDelayedAction');
const utils = require('./utils');
const { waitForDebugger } = require('inspector');

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused variable waitForDebugger.
const result = await energyScan.start().promise;
return result.payload;

const BLANK_EUI64 = "0xFFFFFFFFFFFFFFFF";

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused variable BLANK_EUI64.
return result.payload;

const BLANK_EUI64 = "0xFFFFFFFFFFFFFFFF";
const SLEEPY = 0xffff;

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused variable SLEEPY.
let payload = ZDO.Buffalo.buildRequest(false, clusterId, [11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26], 0x05, undefined, 0, undefined);
this.warn(`Payload is [${JSON.stringify(payload)}]`);
result = await this.herdsman.adapter.sendZdo(0x0, 0x0, clusterId , payload, false);
this.warn(`result is ${JSON.stringify(result)}`)

Check notice

Code scanning / CodeQL

Semicolon insertion Note

Avoid automated semicolon insertion (90% of all statements in
the enclosing function
have an explicit semicolon).
@@ -706,12 +718,15 @@
if (!c.hasOwnProperty('key') && c.hasOwnProperty('convertSet') && converter === undefined)
{
converter = c;

if (has_elevated_debug) this.log.warn(`ELEVATED: setting converter to keyless converter for ${deviceID} of type ${model}`)

Check notice

Code scanning / CodeQL

Semicolon insertion Note

Avoid automated semicolon insertion (91% of all statements in
the enclosing function
have an explicit semicolon).
this.log.debug('setting converter to keyless converter')
continue;
}
if (c.key.includes(stateDesc.prop) || c.key.includes(stateDesc.setattr) || c.key.includes(stateDesc.id))
{
this.log.debug(`${(converter===undefined?'Setting':'Overriding')}' converter to converter with key(s)'${JSON.stringify(c.key)}}`)
if (has_elevated_debug) this.log.warn(`ELEVATED: ${(converter===undefined?'Setting':'Overriding')}' converter to converter with key(s)'${JSON.stringify(c.key)}}`)

Check notice

Code scanning / CodeQL

Semicolon insertion Note

Avoid automated semicolon insertion (91% of all statements in
the enclosing function
have an explicit semicolon).
Group delete
Outdated error message
bugfix
@asgothian asgothian merged commit 40073e0 into ioBroker:master Oct 25, 2024
4 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant