Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extron 0.2.15 to stable #3886

Merged
merged 1 commit into from
Aug 17, 2024
Merged

Conversation

Bannsaenger
Copy link
Contributor

Please update my adapter ioBroker.extron to version 0.2.15.

This pull request was created by https://www.iobroker.dev c0726ff.

@github-actions github-actions bot added Stable auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review labels Aug 5, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Aug 5, 2024

@Bannsaenger

Any adapter revision released to stable MUST have working Github based standard tests. Your tests fail.
The reason is that you merge eslint to 9.x.x while still using an old configuration.

Suggested solution:
REVERT PR Bannsaenger/ioBroker.extron#22 by selecting the revert button at PR and merge the created new PR. I've already don ethe first step and created PR Bannsaenger/ioBroker.extron#24: Please allow tests to run and if OK merge ther PR. This will downgrade eslint to 8.57.0 and should revert checks to a working configuration.

In addition please fix at least the Errors reported by adapterchecker (see above and Bannsaenger/ioBroker.extron#23). It's sufficient to fix the errors

  • ❗ [E026] "{'engines': {'node'>='16'}}" is required at package.json, "{'engines':{'node'>='18'}}" is recommened - BUT PLEASE SEE BELOW
  • ❗ [E162] js-controller 4.0.15 listed as dependency but 4.0.24 is required as minimum, 5.0.19 is recommended. Please update dependency at io-package.json.
  • ❗ [E204] Version "0.2.16" listed at common.news at io-package.json does not exist at NPM. Please remove from news section.

And as a last point:
You currently have tests for node.js 20 and 22 configured at test-and-release workflow. So please EITHER add node 18 tests to your test matrix OR add 'engines': { 'node' >= '20'} to package.json.

Please drop a node as soon as those issues are fixed.
at GitHu. a new release is NOT required.

reminder 13.8.2024

@mcm1957 mcm1957 added the ON HOLD PR is set ON HOLD due to pending question or major issues. label Aug 5, 2024
@github-actions github-actions bot deleted a comment from mcm1957 Aug 8, 2024
@github-actions github-actions bot added the *📬 a new comment has been added label Aug 9, 2024
@github-actions github-actions bot deleted a comment from Bannsaenger Aug 9, 2024
@mcm1957 mcm1957 added new at STABLE and removed *📬 a new comment has been added must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review ON HOLD PR is set ON HOLD due to pending question or major issues. labels Aug 10, 2024
@mcm1957 mcm1957 changed the title Update extron to 0.2.15 Add extron 0.2.15 to stable Aug 10, 2024
@github-actions github-actions bot added the *📬 a new comment has been added label Aug 12, 2024
Copy link

Automated adapter checker

ioBroker.extron

Downloads Number of Installations (latest) Number of Installations (stable) - Test and Release
NPM

👍 No errors found

Adapter releases: https://www.iobroker.dev/adapter/extron/releases
Adapter statistic: https://www.iobroker.dev/adapter/extron/statistics

History and usage information for release 0.2.15:

0.2.15 created 11.6.2024 (62 days old)
5 users (62.50%)

stable release not yet available

Please verify that this PR really tries to update to release 0.2.15!

Add comment "RE-CHECK!" to start check anew

@github-actions github-actions bot deleted a comment from Bannsaenger Aug 12, 2024
@mcm1957 mcm1957 removed *📬 a new comment has been added 13.8.2024 labels Aug 13, 2024
@mcm1957 mcm1957 merged commit 144ba96 into ioBroker:master Aug 17, 2024
24 checks passed
@mcm1957
Copy link
Collaborator

mcm1957 commented Aug 17, 2024

Your Adapter has been added to stable repository. If you like you can extend the news message here:

https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/history/history.md

If you add some more information / description, please consider to add this information to README.md too.

If you have any questions related to the news file, please contact @Apollon77 for further information.

Please note, that the PR announcing the new adapter at stable might not be merged.
https://github.com/ioBroker/ioBroker.docs/pull/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias new at STABLE Stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants