fix: only override struct description if tag is set #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good, and I know this is tiny, but some tests to make sure it doesn't break again would be great! Thanks. |
|
@samlown sure! I'll add some. |
|
@samlown done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that if you use JSONSchemaExtend to set the description of a nested struct, it would be overwritten by the lookup of
jsonschema_descriptionon the parent field even if that tag was not provided.This change makes sure that the tag is actually set, even if it's empty, and only overwrites the description if that is so. This allows the parent to override or remove the description if it wishes.