Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate types on common package #1601

Merged
merged 3 commits into from
Nov 2, 2024

Conversation

notaphplover
Copy link
Member

Description

  • Updated ServiceIdentifier, LazyServiceIdentifier and Newable to be extracted from @inversify/common.

Motivation and Context

In order to migrate slowly but surely our code base to the monorepo, packages are being extracted. Once they are extracted, this repository is starting to delegate on them.

How Has This Been Tested?

Tests run successfully.

Types of changes

  • Updated docs / Refactor code / Added a tests case (non-breaking change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the changelog.

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.75%. Comparing base (1d829c6) to head (d72e6ba).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1601      +/-   ##
==========================================
- Coverage   99.75%   99.75%   -0.01%     
==========================================
  Files          52       51       -1     
  Lines        1623     1617       -6     
  Branches      210      210              
==========================================
- Hits         1619     1613       -6     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@notaphplover notaphplover merged commit 3761eb2 into master Nov 2, 2024
10 checks passed
@notaphplover notaphplover deleted the refactor/delegate-types-on-common-package branch November 2, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant