Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUI] Make breadcrumbs adjustable #8027

Merged
merged 22 commits into from
Feb 11, 2025

Conversation

matmair
Copy link
Member

@matmair matmair commented Aug 28, 2024

Makes usage of breadcrumbs more uniform and adds a user setting to optionally show the current item in the breadcrumbs too.

@matmair matmair added the User Interface Related to the frontend / User Interface label Aug 28, 2024
@matmair matmair added this to the 0.17.0 milestone Aug 28, 2024
@matmair matmair self-assigned this Aug 28, 2024
Copy link

netlify bot commented Aug 28, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit f946fed
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/67aa92457d4f8c000889dca6
😎 Deploy Preview https://deploy-preview-8027--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 94 (🔴 down 2 from production)
Accessibility: 89 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@matmair
Copy link
Member Author

matmair commented Aug 28, 2024

see #7962

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.50%. Comparing base (8bea3ca) to head (f946fed).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/src/components/nav/PageDetail.tsx 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8027      +/-   ##
==========================================
- Coverage   85.54%   85.50%   -0.05%     
==========================================
  Files        1177     1177              
  Lines       52024    52176     +152     
  Branches     2118     2120       +2     
==========================================
+ Hits        44503    44611     +108     
- Misses       6989     7024      +35     
- Partials      532      541       +9     
Flag Coverage Δ
backend 87.35% <ø> (-0.02%) ⬇️
pui 69.26% <66.66%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat
Copy link
Member

@matmair it'd be great to get this one closed out soon if we can :)

@matmair matmair modified the milestones: 0.17.0, 1.0.0 Nov 24, 2024
@matmair
Copy link
Member Author

matmair commented Feb 10, 2025

@SchrodingersGat ready for review and merge

@SchrodingersGat
Copy link
Member

@matmair looks very good, just a small change requested regarding variable naming

@SchrodingersGat SchrodingersGat merged commit d569dbe into inventree:master Feb 11, 2025
27 checks passed
@SchrodingersGat SchrodingersGat deleted the pui-adjust-breadcrumbs branch February 11, 2025 00:37
@SchrodingersGat
Copy link
Member

Thanks @matmair :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Interface Related to the frontend / User Interface
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants