Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approvals #5095

Closed
wants to merge 62 commits into from
Closed

Approvals #5095

wants to merge 62 commits into from

Conversation

matmair
Copy link
Member

@matmair matmair commented Jun 23, 2023

Simplified implementation of approvals for orders. Includes building blocks for a more generalized rules and templates driven approach.

Function

This PR adds approvals (optionally) for POs. You can enable them in settings (including minimum approvers and maximum rejections). After that POs can only be placed once they are approved.

Notifications

Notifications will be sent out to the responsible user/group:

  • when approval starts
  • on each approval decision
  • after being rejected (PO will be cancelled)
  • after being approved (PO will be moved to placed)

UI

As an experiment, I just implemented this in P UI. While the order views are not ready in P UI, approvals are.

Next steps

This is an MVP, I opened an epic for further improvements #5097.
While this PR adds a business logic and UI for PO approvals, approvals are a first-class citizen implementation-wise. They can be used as-is for any model and adding UI elements for that should be simple. The default rules engine is also simple right now but designed for complex requirements. If there is interest this can be extended.

Still to address

Preview Give feedback

Closes #3501

Add approval data

Co-authored-by: Matthias Mair <[email protected]>
@matmair matmair requested a review from SchrodingersGat as a code owner June 23, 2023 15:47
@matmair matmair marked this pull request as draft June 23, 2023 15:47
@matmair matmair changed the title Approvals upstreaming (#2) Approvals Jun 23, 2023
@matmair matmair self-assigned this Jun 23, 2023
@matmair matmair added enhancement This is an suggested enhancement or new feature api Relates to the API Add to docs The contents of this issue/PR should be added to the docs order Related to purchase orders / sales orders labels Jun 23, 2023
@matmair matmair added this to the 0.13.0 milestone Jun 26, 2023
@matmair matmair modified the milestones: 0.13.0, 1.0.0 Jul 18, 2023
@netlify
Copy link

netlify bot commented Aug 5, 2023

Deploy Preview for inventree ready!

Name Link
🔨 Latest commit 3b990a8
🔍 Latest deploy log https://app.netlify.com/sites/inventree/deploys/64f9b10c78eba300084ad0ac
😎 Deploy Preview https://deploy-preview-5095--inventree.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100
Accessibility: 86
Best Practices: 100
SEO: 70
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@matmair matmair modified the milestones: 1.0.0, 0.13.0 Aug 15, 2023
@matmair matmair mentioned this pull request Aug 16, 2023
2 tasks
@matmair matmair marked this pull request as ready for review August 16, 2023 23:13
@matmair
Copy link
Member Author

matmair commented Aug 16, 2023

@inventree/triage this would be ready for a review round.
The order view in P UI is not done by any means, I just added the skeleton needed to show how that could be integrated pending on finalisation of the design.

@matmair
Copy link
Member Author

matmair commented Aug 17, 2023

I updated the description with the things I found to be still missing after a few hours away from this.

@matmair matmair closed this Sep 15, 2023
@matmair matmair deleted the approval-upstream branch September 15, 2023 00:27
This was referenced Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add to docs The contents of this issue/PR should be added to the docs api Relates to the API enhancement This is an suggested enhancement or new feature order Related to purchase orders / sales orders
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FR] Purchase Order Approvals
2 participants