Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

base: add group handler #302

Merged
merged 1 commit into from
Jun 14, 2023
Merged

base: add group handler #302

merged 1 commit into from
Jun 14, 2023

Conversation

TLGINO
Copy link
Contributor

@TLGINO TLGINO commented Apr 11, 2023 •
edited by jrcastro2
Loading

@TLGINO TLGINO force-pushed the feat/groups-membership-support branch from 92d4aa8 to 3c55612 Compare May 8, 2023 07:09
@jrcastro2 jrcastro2 force-pushed the feat/groups-membership-support branch from aeea751 to 07b10b8 Compare May 12, 2023 14:48
@TLGINO TLGINO force-pushed the feat/groups-membership-support branch 2 times, most recently from d0ed5a3 to 8bc5f6f Compare May 13, 2023 10:39
@TLGINO
Copy link
Contributor Author

TLGINO commented May 13, 2023

List of dependencies:

image

Tests passing localy:

image

Disclaimer: Alembic tests marked as skipped

@jrcastro2 jrcastro2 force-pushed the feat/groups-membership-support branch from 8bc5f6f to 2da0d98 Compare May 15, 2023 07:48
@jrcastro2 jrcastro2 marked this pull request as ready for review May 16, 2023 12:53
@jrcastro2 jrcastro2 force-pushed the feat/groups-membership-support branch 3 times, most recently from 79d890f to de3389a Compare May 19, 2023 16:11
@jrcastro2 jrcastro2 force-pushed the feat/groups-membership-support branch 2 times, most recently from 510141a to 8ca974e Compare May 25, 2023 13:29
ntarocco
ntarocco reviewed May 25, 2023
View reviewed changes
invenio_oauthclient/handlers/base.py Outdated Show resolved Hide resolved
invenio_oauthclient/handlers/base.py Outdated Show resolved Hide resolved
invenio_oauthclient/handlers/base.py Outdated Show resolved Hide resolved
tests/test_handlers_rest.py Show resolved Hide resolved
@jrcastro2 jrcastro2 force-pushed the feat/groups-membership-support branch from 8ca974e to 590ae0b Compare May 31, 2023 09:00
ntarocco
ntarocco approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@ntarocco ntarocco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

invenio_oauthclient/handlers/base.py Show resolved Hide resolved
invenio_oauthclient/handlers/base.py Show resolved Hide resolved
ppanero
ppanero reviewed Jun 12, 2023
View reviewed changes
Copy link
Member

@ppanero ppanero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a groups_handler test, however I'm not sure how feasible is to implement that. Maybe checking the feasibility of implementing a test to check it is called? (e.g. using assert_called)

tests/test_app.py Show resolved Hide resolved
@kpsherva kpsherva changed the title wip: groups handler base: add group handler Jun 12, 2023
@jrcastro2 jrcastro2 force-pushed the feat/groups-membership-support branch 3 times, most recently from 8fb6d45 to 3bf1273 Compare June 13, 2023 12:34
@TLGINO @jrcastro2
base: add group handler
1dc4727 
* roles integration for groups handler
* added dummy handler for groups
* closes inveniosoftware/invenio-app-rdm#2186

Co-authored-by: jrcastro2 <[email protected]>
@jrcastro2 jrcastro2 force-pushed the feat/groups-membership-support branch from 3bf1273 to 1dc4727 Compare June 14, 2023 15:45
@kpsherva kpsherva merged commit e64a722 into inveniosoftware:master Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrcastro2 jrcastro2 jrcastro2 left review comments

@ppanero ppanero ppanero left review comments

@ntarocco ntarocco ntarocco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Groups membership support
5 participants
@TLGINO @ntarocco @ppanero @jrcastro2 @kpsherva