Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noref more permissive gnd uri handling #114

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

karkraeg
Copy link
Member

@karkraeg karkraeg commented Jan 13, 2025

❤️ Thank you for your contribution!

Description

This PR aims at simplifying the process of adding a GND ID to a person in the creatibutors modal. Until now users could only paste the actual GND ID, not one of the GND URIs. When researching a GND URI the Website of the german national library looks like this:

image

So most people will just copy and paste this URI. When then saving or publishing the draft in RDM there will be a "Creators: No valid scheme recognized for identifier." error, which in our opinion is a major inconvenience.

This PR allows for pasting both http://d-nb.info/gnd/<id> and https://d-nb.info/gnd/<id> in addition to GND:<id>, gnd:<id> and <id>. The normalization step is the same as before.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant