Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: configure Flask-KVSession #222

Closed
wants to merge 1 commit into from
Closed

config: configure Flask-KVSession #222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions {{cookiecutter.project_shortname}}/{{cookiecutter.package_name}}/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,15 @@ def _(x):
#: client. Set to False, in case of doubt.
ACCOUNTS_USERINFO_HEADERS = True

# Sessions
# ========
#: SameSite cookie type to be used to store user sessions.
SESSION_COOKIE_SAMESITE = 'Strict'

#: Session maniputalion interface (Flask-KVSession).
SESSION_INTERFACE_FACTORY = \
'invenio_accounts.sessions:KVSessionInterfaceStoreAuthenticated'
Comment on lines +96 to +97
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially decided to be set by Invenio-Accounts but there is no guarantee that Invenio-Accounts will be loaded before Flask-KVSession-Invenio.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is Flask-KVSession-Initialised? I think there's potentially something if it's loaded before Invenio-Accounts

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had an extra check - it's because the variables are filtered out here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, wrong highlight - here


# Celery configuration
# ====================

Expand Down