fix: suggest applied controls on audit creation

[nas-tabchiche]

Summary by CodeRabbit

• Bug Fixes
  • Updated the logic for creating applied controls in compliance assessments to reference the correct control relationships.

[coderabbitai]

Walkthrough

The pull request introduces a modification in the perform_create method of the ComplianceAssessmentViewSet class within the backend core views. The change involves altering the relationship accessed when creating applied controls, specifically switching from requirement__control_suggestions to requirement__reference_controls. This adjustment suggests a refinement in how applied controls are generated based on requirement relationships, potentially reflecting an update in the data model or business logic for compliance assessments.

Changes

File	Change Summary
backend/core/views.py	Updated perform_create method in ComplianceAssessmentViewSet to use requirement__reference_controls instead of requirement__control_suggestions

Poem

🐰 In the realm of code, a subtle shift appears,
Reference controls now replace suggestions' cheers
A rabbit's whisker twitches with delight
As data paths realign, just right!
Compliance dancing to a new refrain 🕺

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 255af83 and 68793c7.

📒 Files selected for processing (1)

• backend/core/views.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (11)

• GitHub Check: startup-docker-compose-test
• GitHub Check: startup-functional-test (3.12)
• GitHub Check: functional-tests (3.12, chromium)
• GitHub Check: enterprise-startup-functional-test (3.12)
• GitHub Check: enterprise-functional-tests (3.12, chromium)
• GitHub Check: ruff (3.12)
• GitHub Check: enterprise-startup-docker-compose-test
• GitHub Check: test (3.12)
• GitHub Check: build (3.12)
• GitHub Check: Analyze (python)
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (1)

backend/core/views.py (1)

3507-3507: Verify reference controls setup and add documentation.

The change from control_suggestions to reference_controls looks good, but let's ensure all reference controls are properly set up.

1. Run this script to verify reference controls are properly set up:

2. Consider adding a comment explaining this relationship change:

                assessments = instance.requirement_assessments.all().prefetch_related(
+                   # Using reference_controls instead of control_suggestions for better control management
                    "requirement__reference_controls"
                )

✅ Verification successful

The change to reference_controls is correct and properly integrated

The switch from control_suggestions to reference_controls is consistent with the codebase's data model and is properly supported by database migrations. All related code uses the new field name consistently.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that reference controls exist and are properly linked to requirements.

# Test: Check for requirements without reference controls
ast-grep --pattern $'class RequirementNode {
  $$$
  reference_controls = $$$
  $$$
}'

# Test: Check for any remaining usage of control_suggestions
rg -A 5 $'control_suggestions'

Length of output: 117

---

Script:

#!/bin/bash
# Search for model definitions and field references
rg -l "class.*Requirement" --type py
rg "reference_controls" --type py -C 3
rg "control_suggestions" --type py -C 3

# Check migrations
fd "migrations" -e py -x cat {} | grep -E "control_suggestions|reference_controls"

Length of output: 38211

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.