chore: adapt security exceptions AutocompleteSelect forms

intuitem · Feb 11, 2025 · 9743d05 · 9743d05
1 parent bd05a85
commit 9743d05
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 11 deletions.
diff --git a/frontend/src/lib/components/Forms/ModelForm/AppliedControlPolicyForm.svelte b/frontend/src/lib/components/Forms/ModelForm/AppliedControlPolicyForm.svelte
@@ -90,7 +90,8 @@
 		<AutocompleteSelect
 			{form}
 			multiple
-			options={getOptions({ objects: model.foreignKeys['security_exceptions'] })}
+			optionsEndpoint="security-exceptions"
+			optionsExtraFields={[['folder', 'str']]}
 			field="security_exceptions"
 			cacheLock={cacheLocks['security_exceptions']}
 			bind:cachedValue={formDataCache['security_exceptions']}

diff --git a/frontend/src/lib/components/Forms/ModelForm/AssetForm.svelte b/frontend/src/lib/components/Forms/ModelForm/AssetForm.svelte
@@ -113,7 +113,8 @@
 <AutocompleteSelect
 	{form}
 	multiple
-	options={getOptions({ objects: model.foreignKeys['security_exceptions'] })}
+	optionsEndpoint="security-exceptions"
+	optionsExtraFields={[['folder', 'str']]}
 	field="security_exceptions"
 	cacheLock={cacheLocks['security_exceptions']}
 	bind:cachedValue={formDataCache['security_exceptions']}

diff --git a/frontend/src/lib/components/Forms/ModelForm/SecurityExceptionForm.svelte b/frontend/src/lib/components/Forms/ModelForm/SecurityExceptionForm.svelte
@@ -18,7 +18,7 @@
 <HiddenInput {form} field="requirement_assessments" />
 <AutocompleteSelect
 	{form}
-	options={getOptions({ objects: model.foreignKeys['folder'] })}
+	optionsEndpoint="folders?content_type=DO&content_type=GL"
 	field="folder"
 	cacheLock={cacheLocks['folder']}
 	bind:cachedValue={formDataCache['folder']}
@@ -35,15 +35,17 @@
 <AutocompleteSelect
 	{form}
 	multiple
-	options={getOptions({ objects: model.foreignKeys['owners'], label: 'email' })}
+	optionsEndpoint="users?is_third_party=false"
+	optionsLabelField="email"
 	field="owners"
 	cacheLock={cacheLocks['owners']}
 	bind:cachedValue={formDataCache['owners']}
 	label={m.owner()}
 />
 <AutocompleteSelect
 	{form}
-	options={getOptions({ objects: model.foreignKeys['approver'], label: 'email' })}
+	optionsEndpoint="users?is_third_party=false"
+	optionsLabelField="email"
 	field="approver"
 	cacheLock={cacheLocks['approver']}
 	bind:cachedValue={formDataCache['approver']}

diff --git a/frontend/src/lib/components/Forms/ModelForm/VulnerabilitiesForm.svelte b/frontend/src/lib/components/Forms/ModelForm/VulnerabilitiesForm.svelte
@@ -57,7 +57,8 @@
 <AutocompleteSelect
 	{form}
 	multiple
-	options={getOptions({ objects: model.foreignKeys['security_exceptions'] })}
+	optionsEndpoint="security-exceptions"
+	optionsExtraFields={[['folder', 'str']]}
 	field="security_exceptions"
 	cacheLock={cacheLocks['security_exceptions']}
 	bind:cachedValue={formDataCache['security_exceptions']}

diff --git a/frontend/src/routes/(app)/(internal)/risk-scenarios/[id=uuid]/edit/+page.svelte b/frontend/src/routes/(app)/(internal)/risk-scenarios/[id=uuid]/edit/+page.svelte
@@ -194,7 +194,8 @@
 					<AutocompleteSelect
 						multiple
 						form={_form}
-						options={getOptions({ objects: data.foreignKeys['security_exceptions'] })}
+						optionsEndpoint="security-exceptions"
+						optionsExtraFields={[['folder', 'str']]}
 						field="security_exceptions"
 						label={m.securityExceptions()}
 					/>

diff --git a/frontend/src/routes/(app)/(third-party)/requirement-assessments/[id=uuid]/edit/+page.svelte b/frontend/src/routes/(app)/(third-party)/requirement-assessments/[id=uuid]/edit/+page.svelte
@@ -493,10 +493,8 @@
 								<AutocompleteSelect
 									multiple
 									{form}
-									options={getOptions({
-										objects: $page.data.model.foreignKeys['security_exceptions'],
-										extra_fields: [['folder', 'str']]
-									})}
+									optionsEndpoint="security-exceptions"
+									optionsExtraFields={[['folder', 'str']]}
 									field="security_exceptions"
 								/>
 								<ModelTable