Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change log location #88

Closed
wants to merge 1 commit into from
Closed

Conversation

nick2432
Copy link

@nick2432 nick2432 commented Jul 23, 2024

Changes made

I updated the directory where log files are written from ./jobs/ to ./jobs/logs/. Previously, logs were being written directly to the /jobs directory, which was not the intended location. By changing the path to ./jobs/logs/, the logs will now be stored in the designated subdirectory, improving organization and making it easier to manage log files. This update helps ensure that logs are kept separate from other files in the /jobs directory, adhering to a cleaner and more logical directory structure.

##Screenshots
Screenshot from 2024-07-23 10-46-17

Issue Resolved

Fixes #73

@CorentinB CorentinB requested a review from equals215 July 23, 2024 08:09
@CorentinB CorentinB added the bug Something isn't working label Jul 23, 2024
@CorentinB
Copy link
Collaborator

Thanks @nick2432! Problem is that with this way of adding the logs path, it doesn't respect --jobs.

@equals215
Copy link
Member

Thanks @nick2432! Problem is that with this way of adding the logs path, it doesn't respect --jobs.

@CorentinB did it ever? Wasn't aware of that

@CorentinB
Copy link
Collaborator

Thanks @nick2432! Problem is that with this way of adding the logs path, it doesn't respect --jobs.

@CorentinB did it ever? Wasn't aware of that

Yes basically if --jobs isn't used, "logs", "warcs" etc are in the "jobs" directory, if --jobs is specified then it is put in the given directory's name, under "jobs". So "jobs/logs" becomes "jobs/whatever/logs".

Copy link
Member

@equals215 equals215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nick2432! Problem is that with this way of adding the logs path, it doesn't respect --jobs.

@CorentinB did it ever? Wasn't aware of that

Yes basically if --jobs isn't used, "logs", "warcs" etc are in the "jobs" directory, if --jobs is specified then it is put in the given directory's name, under "jobs". So "jobs/logs" becomes "jobs/whatever/logs".

You will find the function handleFlagsEdgeCases() in config/config.go. This function is made to handle logic between flags at command runtime.
(and try to write a PR description yourself, this one looks very AI generated 😉)

@CorentinB CorentinB changed the title Chage log location Change log location Jul 23, 2024
@CorentinB
Copy link
Collaborator

Hi @nick2432, do you know when the PR will be finished? Let us know if you need any help.

@nick2432
Copy link
Author

nick2432 commented Aug 4, 2024

Hi @nick2432, do you know when the PR will be finished? Let us know if you need any help.

sorry, ya I will start working today
I had an interview, so I was giving that

@nick2432
Copy link
Author

nick2432 commented Aug 4, 2024

Hi @nick2432, do you know when the PR will be finished? Let us know if you need any help.

I will take 2-3 days

@CorentinB
Copy link
Collaborator

Hi @nick2432, sorry but it took really too long. I implemented the necessary changes myself: 6ab2d19

@CorentinB CorentinB closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs are written to the wrong location
3 participants