-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change log location #88
Conversation
Thanks @nick2432! Problem is that with this way of adding the logs path, it doesn't respect --jobs. |
@CorentinB did it ever? Wasn't aware of that |
Yes basically if --jobs isn't used, "logs", "warcs" etc are in the "jobs" directory, if --jobs is specified then it is put in the given directory's name, under "jobs". So "jobs/logs" becomes "jobs/whatever/logs". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nick2432! Problem is that with this way of adding the logs path, it doesn't respect --jobs.
@CorentinB did it ever? Wasn't aware of that
Yes basically if --jobs isn't used, "logs", "warcs" etc are in the "jobs" directory, if --jobs is specified then it is put in the given directory's name, under "jobs". So "jobs/logs" becomes "jobs/whatever/logs".
You will find the function handleFlagsEdgeCases()
in config/config.go
. This function is made to handle logic between flags at command runtime.
(and try to write a PR description yourself, this one looks very AI generated 😉)
Hi @nick2432, do you know when the PR will be finished? Let us know if you need any help. |
sorry, ya I will start working today |
I will take 2-3 days |
Changes made
I updated the directory where log files are written from ./jobs/ to ./jobs/logs/. Previously, logs were being written directly to the /jobs directory, which was not the intended location. By changing the path to ./jobs/logs/, the logs will now be stored in the designated subdirectory, improving organization and making it easier to manage log files. This update helps ensure that logs are kept separate from other files in the /jobs directory, adhering to a cleaner and more logical directory structure.
##Screenshots
Issue Resolved
Fixes #73