fix: crash when --api is not set (#79)

Prometheus was always expecting to be there but API is not always set when crawls are ran. This resolves that issue.
internetarchive · Jul 15, 2024 · de41b1d · de41b1d
1 parent a1f0efd
commit de41b1d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/cmd/utils.go b/cmd/utils.go
@@ -140,9 +140,10 @@ func InitCrawlWithCMD(flags config.Flags) *crawl.Crawl {
 
 	c.API = flags.API
 	c.APIPort = flags.APIPort
-	c.PrometheusMetrics = new(crawl.PrometheusMetrics)
-	c.PrometheusMetrics.Prefix = flags.PrometheusPrefix
-
+	if c.API {
+		c.PrometheusMetrics = new(crawl.PrometheusMetrics)
+		c.PrometheusMetrics.Prefix = flags.PrometheusPrefix
+	}
 	if flags.UserAgent != "Zeno" {
 		c.UserAgent = flags.UserAgent
 	} else {

diff --git a/internal/pkg/crawl/capture.go b/internal/pkg/crawl/capture.go
@@ -35,7 +35,7 @@ func (c *Crawl) executeGET(item *queue.Item, req *http.Request, isRedirection bo
 	)
 
 	defer func() {
-		if c.API {
+		if c.PrometheusMetrics != nil {
 			c.PrometheusMetrics.DownloadedURI.Inc()
 		}