Skip to content

Commit

Permalink
fix: disable handover by default until it's fixed
Browse files Browse the repository at this point in the history
  • Loading branch information
CorentinB committed Sep 1, 2024
1 parent 8cdd3d9 commit 5aed272
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion cmd/get.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ func getCMDsFlags(getCmd *cobra.Command) {
getCmd.PersistentFlags().StringSlice("exclude-string", []string{}, "Discard any (discovered) URLs containing this string.")
getCmd.PersistentFlags().Bool("random-local-ip", false, "Use random local IP for requests. (will be ignored if a proxy is set)")
getCmd.PersistentFlags().Int("min-space-required", 20, "Minimum space required in GB to continue the crawl.")
getCmd.PersistentFlags().Bool("no-handover", false, "Disable the handover mechanism that dispatch URLs via a buffer before enqueuing on disk.")
getCmd.PersistentFlags().Bool("handover", false, "Use the handover mechanism that dispatch URLs via a buffer before enqueuing on disk. (UNSTABLE)")
getCmd.PersistentFlags().Bool("ultrasafe-queue", false, "Don't use committed batch writes to the WAL and instead fsync() after each write.")

// Proxy flags
Expand Down
2 changes: 1 addition & 1 deletion config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ type Config struct {
HQContinuousPull bool `mapstructure:"hq-continuous-pull"`
HQRateLimitSendBack bool `mapstructure:"hq-rate-limiting-send-back"`
NoStdoutLogging bool `mapstructure:"no-stdout-log"`
NoHandover bool `mapstructure:"no-handover"`
NoBatchWriteWAL bool `mapstructure:"ultrasafe-queue"`
Handover bool `mapstructure:"handover"`
}

var (
Expand Down
2 changes: 1 addition & 1 deletion internal/pkg/crawl/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ func GenerateCrawlConfig(config *config.Config) (*Crawl, error) {
c.HQRateLimitingSendBack = config.HQRateLimitSendBack

// Handover mechanism
c.UseHandover = !config.NoHandover
c.UseHandover = config.Handover

c.UseCommit = !config.NoBatchWriteWAL

Expand Down

0 comments on commit 5aed272

Please sign in to comment.