[BUG] Internal server error when taking too long to accept/decline grant

[sidvishnoi]

Steps to reproduce

1. Create an outgoing payment grant and reach the /grant-interactions page.
2. Do nothing for long enough (haven't checked what's the timeout for that) MK: it is 10 mins by default
3. Click accept or decline

Expected result

interact.finish.uri (redirect) to be followed with a grant failure indication in URL parameter.

Actual result

A modal with message "Internal server error" is shown.

Screenshots or videos

Additional context

No response

Operating system

Windows, macOS, Linux

Operating system version

No response

Browsers

Chrome, Microsoft Edge, Firefox

Browser version

No response

[dragosp1011]

If the interaction is expired and I am trying to finish the interaction, it will not redirect back to the boutique.
Looks like some changes are required in rafiki for the redirection to happen even if the interaction is expired.

[mkurapov]

@dragosp1011 To double check, is the error message is coming from the "finish" interaction route or the "accept/deny" route?

[dragosp1011]

I tested with boutioque locally. Currently a Internal Server Error message will appear and it does nothing after closing the modal. The internal error message is from calling the "accept/deny" route. The response form rafiki is Bad request without specific reasons why.
I tried to add the finish call when closing the error modal so the user is redirected back to the boutique and the screenshot above was the result.

[mkurapov]

Got it, it looks like the 400 message you are getting without any other details is because we don't have nice formatting for GNAP errors on the interaction server yet (PR: interledger/rafiki#3094)

Otherwise it should be

        error: {
          code: "invalid_interaction",
          description: "invalid interaction"
        }

The screenshot above makes sense for the finish route, since at that point, the AS session/cookie is expired. Left comment on Slack.

[Tymmmy]

Closing this issue as there is a ticket opened in Rafiki for it