Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle expired interactions gracefully #3318

Open
3 tasks
mkurapov opened this issue Feb 24, 2025 · 0 comments
Open
3 tasks

Handle expired interactions gracefully #3318

mkurapov opened this issue Feb 24, 2025 · 0 comments
Labels
pkg: auth Changes in the GNAP auth package.

Comments

@mkurapov
Copy link
Contributor

mkurapov commented Feb 24, 2025

Context

  • After looking through the test wallet issue [BUG] Internal server error when taking too long to accept/decline grant testnet#1917, we noticed that we can handle the interaction expiry error better in the auth service
  • First, we need to return proper errors in the interaction routes, such that the IDP can know why the interaction choice call failed (like expiry). This is being done in feat(auth): use gnap error middleware on idp api #3094.
  • Second, in the finish route handler, instead of checking the session nonce first, we should check that the interaction has expired. If it has, we should redirect back to the client redirect URI with result=interaction_expired query param. If not expired, we should then check the session nonce.
  • In general, other than the invalid session error, we should always redirect back to the client with the corresponding query param in the URL.

Todos

@github-project-automation github-project-automation bot moved this to Backlog in Rafiki Feb 24, 2025
@mkurapov mkurapov added the pkg: auth Changes in the GNAP auth package. label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: auth Changes in the GNAP auth package.
Projects
Status: Backlog
Development

No branches or pull requests

1 participant