feat(backend): redirect to webpage when querying payment pointer in browser

[cozminu]

Changes proposed in this pull request

• when a request comes from the browser (containing header Accept with text/html) on the payment pointer url, we redirect to wallet website

Context

fixes #3268

Checklist

• Related issues linked using fixes #number
• Tests added/updated
• Make sure that all checks pass
• Bruno collection updated (if necessary)
• Documentation issue created with user-docs label (if necessary)
• OpenAPI specs updated (if necessary)

[netlify]

✅ Deploy Preview for brilliant-pasca-3e80ec ready!

Name	Link
🔨 Latest commit	4abf0ff
🔍 Latest deploy log	https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/67c5791ea5b7810008185d46
😎 Deploy Preview	https://deploy-preview-3298--brilliant-pasca-3e80ec.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[mkurapov]

Given that the env should be optional, we should include checking for that in this condition

[cozminu]

got it

rafiki/packages/backend/src/open_payments/wallet_address/routes.ts

Lines 56 to 64 in 4005273

	if (
	deps.config.walletAddressRedirectHtmlPage &&
	ctx.request.header['accept']?.includes('text/html')
	) {
	ctx.set(
	'Location',
	`${deps.config.walletAddressRedirectHtmlPage}/${ctx.request.header['host']}${ctx.request.url}`
	)
	ctx.status = 302

[mkurapov]

Maybe something like WALLET_ADDRESS_REDIRECT_HTML_PAGE? Should be optional as well

[cozminu]

done

rafiki/packages/backend/src/config/app.ts

Line 195 in 4005273

walletAddressRedirectHtmlPage: process.env.WALLET_ADDRESS_REDIRECT_HTML_PAGE,

[mkurapov]

I think this would be good to have as a separate middleware for the wallet address route (and should be the first one registered, since we should redirect as soon as possible, without needing to do other operations)

[cozminu]

Made a separate middleware redirectIfBrowserAcceptsHtml which I put below getWalletAddressUrlFromPath in order to get the processed wallet address instead of redundantly composing it

rafiki/packages/backend/src/app.ts

Lines 674 to 677 in 8c95179

	router.get(
	WALLET_ADDRESS_PATH,
	getWalletAddressUrlFromPath,
	redirectIfBrowserAcceptsHtml,

[mkurapov]

Suggested change

	`${deps.config.walletAddressRedirectHtmlPage}/${ctx.request.header['host']}${ctx.request.url}`
	`${deps.config.walletAddressRedirectHtmlPage}/${ctx.params.walletAddressPath}`

[cozminu]

using walletAddressPath and moved it to the new middleware, but still needed some processing to remove http://

rafiki/packages/backend/src/open_payments/wallet_address/middleware.ts

Lines 126 to 135 in 8c95179

	const walletAddressPath = ctx.walletAddressUrl.replace('https://', '')
	if (
	config.walletAddressRedirectHtmlPage &&
	ctx.request.header['accept']?.includes('text/html')
	) {
	ctx.set(
	'Location',
	`${config.walletAddressRedirectHtmlPage}/${walletAddressPath}`
	)

[mkurapov]

Let's make sure if the integrator enters a walletAddressRedirectHtmlPage with a trailing slash that we don't add the extra /. Something that would happen for sure 😅

[cozminu]

Done

rafiki/packages/backend/src/open_payments/wallet_address/middleware.ts

Lines 132 to 135 in 4abf0ff

	const redirectHtmlPage = config.walletAddressRedirectHtmlPage.replace(
	/\/+$/,
	''
	)