docs: liquidity updates #3241
Merged
docs: liquidity updates #3241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor updates before larger liquidity updates
github-actions
bot
added
the
pkg: documentation
✅ Deploy Preview for brilliant-pasca-3e80ec ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I also updated the accounting concepts page to make the transfer examples at the bottom easier to navigate to |
brad-dow
previously approved these changes
Jan 27, 2025
mkurapov
reviewed
Feb 11, 2025
packages/documentation/src/content/docs/admin/liquidity/asset-liquidity.mdx
Outdated
Show resolved
Hide resolved
packages/documentation/src/content/docs/admin/liquidity/payment-liquidity.mdx
Outdated
Show resolved
Hide resolved
packages/documentation/src/content/docs/admin/liquidity/asset-liquidity.mdx
Outdated
Show resolved
Hide resolved
mkurapov
approved these changes
Feb 12, 2025
| import { CodeBlock, LinkOut } from '@interledger/docs-design-system' | ||
| import IdempotencyNote from '/src/partials/liquidity-idempotency.mdx' | ||
|
|
||
| Asset liquidity is the amount of value, denominated in a given asset, that Rafiki has available to handle cross-currency (foreign exchange) transactions between you and your peer. Whenever an outgoing payment/incoming payment is in a different asset than the peering relationship, the liquidity of asset accounts will change depending on the FX direction. |
There was a problem hiding this comment.
ah, we should also update the overview/concepts/accounting/#asset-liquidity-accounts page with this text for consistency
There was a problem hiding this comment.
I caught that yesterday, so I think we're good here.
Comment on lines
+58
to
+62
| { | ||
| data: { | ||
| success: true | ||
| } | ||
| } |
There was a problem hiding this comment.
Yes, I wonder why prettier didn't format this with quotes 🤔
There was a problem hiding this comment.
Also no quotes in payment-liquidity or two-phase-transfers, just peer 🤷🏻♀️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3139
Split manage liquidity page into multiple pages. Also add wrap to a few code blocks that needed it.