Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backend): tenanted quotes and outgoing payments #3171

Merged
merged 43 commits into from
Feb 17, 2025
Merged

feat(backend): tenanted quotes and outgoing payments #3171

merged 43 commits into from
Feb 17, 2025

Conversation

sanducb
Copy link
Contributor

@sanducb sanducb commented Dec 10, 2024 •
edited
Loading

Changes proposed in this pull request

  • The purpose of this PR is to make quotes and outgoing payments tenanted as per multi-tenant design

Context

fixes #3118 #3119

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

@sanducb sanducb linked an issue Dec 10, 2024 that may be closed by this pull request
[Multi-Tenant] Tenanted Quotes #3118
Closed
4 tasks
@github-actions github-actions bot added type: tests Testing related pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. type: source Changes business logic pkg: auth Changes in the GNAP auth package. pkg: mock-ase pkg: mock-account-service-lib labels Dec 10, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 10, 2024 •
edited
Loading

✅ Deploy Preview for brilliant-pasca-3e80ec ready!

Name Link
🔨 Latest commit 8ef2027
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/6758541a24fdd400087e2d57
😎 Deploy Preview https://deploy-preview-3171--brilliant-pasca-3e80ec.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sanducb sanducb changed the base branch from main to 2893/multi-tenancy-v1 December 10, 2024 14:49
@github-actions github-actions bot removed the pkg: auth Changes in the GNAP auth package. label Dec 17, 2024
@sanducb sanducb changed the title feat(backend): tenanted quotes feat(backend): tenanted quotes and outgoing payments Dec 17, 2024
@sanducb sanducb requested review from mkurapov and njlie December 28, 2024 16:27
@sanducb
Copy link
Contributor Author

sanducb commented Dec 28, 2024 •
edited
Loading

@mkurapov @njlie Quotes related changes can already be reviewed even though the outgoing payments side is not finished yet.

@sanducb sanducb marked this pull request as ready for review February 4, 2025 10:06
@sanducb sanducb requested a review from mkurapov February 12, 2025 10:53
@sanducb
feat: tenanted quotes and outgoing payments - add tenantId to outgoin…
799026a 
…g payments routes, add test cases for unknown tenantId
@sanducb sanducb requested a review from mkurapov February 12, 2025 12:27
@sanducb sanducb requested a review from mkurapov February 13, 2025 13:24
mkurapov
mkurapov reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

@mkurapov mkurapov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final thing, I think we need to use the tenantId in the getWalletAddressUrlFromOutgoingPayment route middleware, just to be on the safe side

njlie
njlie approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@njlie njlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after #3171 (comment)

@sanducb sanducb requested a review from mkurapov February 17, 2025 13:54
mkurapov
mkurapov reviewed Feb 17, 2025
View reviewed changes
Copy link
Contributor

@mkurapov mkurapov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some format check is complaining

packages/backend/src/open_payments/wallet_address/middleware.test.ts
@@ -290,6 +293,58 @@ describe('Wallet Address Middleware', (): void => {
expect(next).toHaveBeenCalled()
})

test('throws error if could not find existing outgoing payment for mismatched tenantId', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have one for getWalletAddressUrlFromQuote as well

@sanducb sanducb requested a review from mkurapov February 17, 2025 15:48
@sanducb sanducb merged commit 52b7c18 into 2893/multi-tenancy-v1 Feb 17, 2025
33 of 37 checks passed
@sanducb sanducb deleted the 3118-multi-tenant-tenanted-quotes branch February 17, 2025 16:14
@golobitch golobitch mentioned this pull request Mar 1, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurapov mkurapov mkurapov approved these changes

@njlie njlie njlie approved these changes

Assignees
No one assigned
Labels
pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. pkg: mock-account-service-lib pkg: mock-ase type: source Changes business logic type: tests Testing related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Multi-Tenant] Tenanted Outgoing Payments [Multi-Tenant] Tenanted Quotes
3 participants
@sanducb @mkurapov @njlie