chore: cleanup comments, join on fees again, fix test

interledger · Feb 26, 2025 · 0ee9794 · 0ee9794
1 parent 3164ed9
commit 0ee9794
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 378 deletions.
diff --git a/packages/backend/src/open_payments/quote/service.test.ts b/packages/backend/src/open_payments/quote/service.test.ts
@@ -377,7 +377,7 @@ describe('QuoteService', (): void => {
     test.each`
       expiryDate                                                            | description
       ${new Date(new Date().getTime() + Config.quoteLifespan - 2 * 60_000)} | ${"the incoming payment's expirataion date"}
-      ${new Date(new Date().getTime() + Config.quoteLifespan + 2 * 60_000)} | ${"the quotation's creation date plus its lifespan"}
+      ${new Date(new Date().getTime() + Config.quoteLifespan + 2 * 60_000)} | ${"the quote's creation date plus its lifespan"}
     `(
       'sets expiry date to $description',
       async ({ expiryDate }): Promise<void> => {
@@ -406,11 +406,13 @@ describe('QuoteService', (): void => {
           .spyOn(paymentMethodHandlerService, 'getQuote')
           .mockResolvedValueOnce(mockedQuote)
 
+        jest.useFakeTimers()
+        const now = Date.now()
+        jest.spyOn(global.Date, 'now').mockImplementation(() => now)
+
         const quote = await quoteService.create(options)
         assert.ok(!isQuoteError(quote))
-        const maxExpiration = new Date(
-          quote.createdAt.getTime() + config.quoteLifespan
-        )
+        const maxExpiration = new Date(now + config.quoteLifespan)
         expect(quote).toMatchObject({
           walletAddressId: sendingWalletAddress.id,
           receiver: options.receiver,