Skip to content

Commit

Permalink
Merge pull request #8 from intergral/watch
Browse files Browse the repository at this point in the history
feat(watch): add watch source to allow for better UI identification
  • Loading branch information
Umaaz authored Dec 14, 2023
2 parents 350deb8 + 1cc3d8c commit 33816f6
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# 1.0.3 (xx/xx/2023)

- **[FEATURE]**: add metric definition models [#6](https://github.com/intergral/deep-proto/pull/6) [@Umaaz](https://github.com/Umaaz)
- **[FEATURE]**: add watch source to models [#8](https://github.com/intergral/deep-proto/pull/8) [@Umaaz](https://github.com/Umaaz)


# 1.0.2 (01/11/2023)
Expand Down
10 changes: 9 additions & 1 deletion deepproto/proto/tracepoint/v1/tracepoint.proto
Original file line number Diff line number Diff line change
Expand Up @@ -96,14 +96,22 @@ message StackFrame {
optional string short_path = 13; // This is the short path to the file (e.g. /simple-app/main.py instead of /home/ben/repo/app/simple-app/main.py).
}

// WatchSource is the logical source of the watch expression used to generate a result.
enum WatchSource {
WATCH = 0; // A user attached this as an expression
LOG = 1; // A watch expression from a log
METRIC = 2; // A watch expression from a metric value or tag
}

// WatchResult is the result of a watch expression being executed.
message WatchResult {
string expression = 1; // the expression executed to collect the data
oneof result {
VariableID good_result = 2; // The VariableID of the variable that represents the result, if the expression completed successfully.
string error_result = 3; // This is to contain the error message generated if the watch expression fails.
}
optional bool from_metric = 4; // Is this the result of a metric, or metric tag
optional bool from_metric = 4; // Is this the result of a metric, or metric tag @Deprecated
WatchSource source = 5; // This is the source of the watch result. e.g. did the watch come from a watch input, a log message or a metric
}

// Snapshot is the result of a tracepoint being executed.
Expand Down

0 comments on commit 33816f6

Please sign in to comment.