fix(name): make default name for distributed mode be 'deep'

intergral · Jan 13, 2025 · 555e921 · 555e921
1 parent 76bf57e
commit 555e921
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/charts/deep-distributed/templates/_helpers.tpl b/charts/deep-distributed/templates/_helpers.tpl
@@ -14,7 +14,7 @@ If release name contains chart name it will be used as a full name.
 {{- if .Values.fullnameOverride }}
 {{- .Values.fullnameOverride | trunc 63 | trimSuffix "-" }}
 {{- else }}
-{{- $name := default .Chart.Name .Values.nameOverride }}
+{{- $name := default "deep" .Values.nameOverride }}
 {{- if contains $name .Release.Name }}
 {{- .Release.Name | trunc 63 | trimSuffix "-" }}
 {{- else }}

diff --git a/charts/deep-distributed/unittests/config_test.yaml b/charts/deep-distributed/unittests/config_test.yaml
@@ -2,8 +2,6 @@ suite: test configmap
 chart:
   version: 9.9.9+test
   appVersion: 1.1.1+test
-release:
-  name: deep
 tests:
   - it: should merge configs
     template: configmap-deep.yaml

diff --git a/makefile b/makefile
@@ -0,0 +1,5 @@
+
+.PHONY: test
+test:
+	helm unittest -f unittests/**/*_test.yaml charts/deep
+	helm unittest -f unittests/**/*_test.yaml charts/deep-distributed