[SYCL] moving kernel_compiler sycl cache testing to its own test. #16727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing some of the 'unsupported-intended' information. This also increments the #include <sycl.hpp> counter, not because the new test does that (it does not), but the kernel string it contains does and that's incorrectly getting picked up by the no_sycl_in_hpp test.
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| @@ -6,7 +6,7 @@ | |||
| // CHECK-DAG: README.md | |||
| // CHECK-DAG: lit.cfg.py | |||
| // | |||
| // CHECK-NUM-MATCHES: 5 | |||
| // CHECK-NUM-MATCHES: 6 | |||
There was a problem hiding this comment.
Took me a moment to realize why this was increasing. I suppose this is a good reason to let it go up.
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moving kernel_compiler sycl cache testing to its own test. Also updating some of the 'unsupported-intended' information. This also increments the #include <sycl.hpp> counter, not because the new test does that (it does not), but the kernel string it contains does and that's incorrectly getting picked up by the no_sycl_in_hpp test.