[SYCL][clang] Always lift SYCL device code restrictions in constant expressions #15573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…contexts Earlier a mechanism to lift SYCL device code restrictions in C++ manifestly constant-evaluated expressions was implemented in the front-end. It was enabled under an option since it wasn't specified. Since then it has been decided to make this behavior default for SYCL 2020. This PR removes the option that was enabling the new behavior and enables it by default.
Fznamznon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Fznamznon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
gmlueck
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Yes, we want this to be the default behavior, not tied to a special option. The matching PR to the SYCL specification is KhronosGroup/SYCL-Docs#388.
smanna12
approved these changes
Oct 2, 2024
srividya-sundaram
approved these changes
Oct 2, 2024
|
@intel/llvm-gatekeepers , could you please merge? This is ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier a mechanism to lift SYCL device code restrictions in C++ manifestly constant-evaluated expressions was implemented in the front-end. It was enabled under an option since it wasn't specified. Since then it has been decided to make this behavior default for SYCL 2020. This PR removes the option that was enabling the new behavior and enables it by default.