Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][Doc] Extension spec for composite devices #11846
[SYCL][Doc] Extension spec for composite devices #11846
Changes from all commits
dfdc22f
8660611
a2a3096
3a18df1
62f48d9
a9272d9
b7f9ed9
b706906
2af17b5
1f1712e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gmlueck : from the definition above:
then
get_composite_devices()
would return the equivalent devices returned byzeDeviceGet
when ZE_FLAT_DEVICE_HIERARCHY is set to COMPOSITE. When it is set to FLAT, thenget_composite_devices()
will return 0, as with FLAT the root devices returned are tiles, so the statement above "the implementation automatically schedules work-items to each of the underlying tiles." doesn't hold.Is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
get_composite_devices
function will return an empty list in both FLAT and COMPOSITE modes. It's only in COMBINED mode where it returns something interesting. In this mode, I believe the statement about distributing work-items to the underlying tiles is true, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dont know if this needs to be reworded? The ONEAPI_DEVICE_SELECTOR is being implemented in the UR, which means will be used by all customers of the UR, not only the dpcpp implementation, oneapi-src/unified-runtime#220.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, DPC++ is the only SYCL implementation that uses the UR. I think we should keep the wording like this for now. We can revisit it if other SYCL implementation start using the UR.
In any event, I think the logic described in this section will probably be located in the DPC++ runtime, not in the UR.