Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistent device config in finetuning and serving yaml #25

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Fix inconsistent device config in finetuning and serving yaml #25

merged 1 commit into from
Jan 4, 2024

Conversation

carsonwang
Copy link
Contributor

closes #11

@carsonwang carsonwang requested a review from jiafuzha January 4, 2024 02:22
jiafuzha
jiafuzha approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@jiafuzha jiafuzha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carsonwang carsonwang merged commit 91f3756 into intel:main Jan 4, 2024
6 checks passed
carsonwang pushed a commit to carsonwang/llm-on-ray that referenced this pull request Jan 9, 2024
@zhangjian94cn
Adapt to ray 2.5.0 for RLHF pipeline (intel#25)
e6e9f93 
* [rlhf] adapt to ray 2.5.0

* [rlhf] add post_init for RewardModel

* [rlhf] support neox reward model

* [rlhf] adapt values dims

* add tensorboard for rm trainer

* remove duplicated code of reward model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiafuzha jiafuzha jiafuzha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent device config in finetuning and serving yaml
2 participants
@carsonwang @jiafuzha