-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to phase and health controllers #1015
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This was referenced Dec 31, 2023
This comment has been minimized.
This comment has been minimized.
This was referenced Jan 1, 2024
diff
config/default/apiextensions.k8s.io_v1_customresourcedefinition_notifications.argocdcommenter.int128.github.io.yaml--- /dev/null
+++ b/tmp/kustomize-action-yb0e32/config/default/apiextensions.k8s.io_v1_customresourcedefinition_notifications.argocdcommenter.int128.github.io.yaml
@@ -0,0 +1,48 @@
+apiVersion: apiextensions.k8s.io/v1
+kind: CustomResourceDefinition
+metadata:
+ annotations:
+ controller-gen.kubebuilder.io/version: v0.12.0
+ name: notifications.argocdcommenter.int128.github.io
+spec:
+ group: argocdcommenter.int128.github.io
+ names:
+ kind: Notification
+ listKind: NotificationList
+ plural: notifications
+ singular: notification
+ scope: Namespaced
+ versions:
+ - name: v1
+ schema:
+ openAPIV3Schema:
+ description: Notification is the Schema for the notifications API
+ properties:
+ apiVersion:
+ description: 'APIVersion defines the versioned schema of this representation
+ of an object. Servers should convert recognized schemas to the latest
+ internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
+ type: string
+ kind:
+ description: 'Kind is a string value representing the REST resource this
+ object represents. Servers may infer this from the endpoint the client
+ submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
+ type: string
+ metadata:
+ type: object
+ spec:
+ description: NotificationSpec defines the desired state of Notification
+ type: object
+ status:
+ description: NotificationStatus defines the observed state of Notification
+ properties:
+ commentState:
+ type: string
+ deploymentState:
+ type: string
+ type: object
+ type: object
+ served: true
+ storage: true
+ subresources:
+ status: {} config/default/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-manager-role.yaml--- a/tmp/kustomize-action-yVzLyf/config/default/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-manager-role.yaml
+++ b/tmp/kustomize-action-yb0e32/config/default/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-manager-role.yaml
@@ -3,32 +3,6 @@ kind: ClusterRole
metadata:
name: argocd-commenter-manager-role
rules:
-- apiGroups:
- - argocdcommenter.int128.github.io
- resources:
- - applicationhealths
- verbs:
- - create
- - delete
- - get
- - list
- - patch
- - update
- - watch
-- apiGroups:
- - argocdcommenter.int128.github.io
- resources:
- - applicationhealths/finalizers
- verbs:
- - update
-- apiGroups:
- - argocdcommenter.int128.github.io
- resources:
- - applicationhealths/status
- verbs:
- - get
- - patch
- - update
- apiGroups:
- argoproj.io
resources: e2e_test/controller/apiextensions.k8s.io_v1_customresourcedefinition_notifications.argocdcommenter.int128.github.io.yaml--- /dev/null
+++ b/tmp/kustomize-action-yb0e32/e2e_test/controller/apiextensions.k8s.io_v1_customresourcedefinition_notifications.argocdcommenter.int128.github.io.yaml
@@ -0,0 +1,48 @@
+apiVersion: apiextensions.k8s.io/v1
+kind: CustomResourceDefinition
+metadata:
+ annotations:
+ controller-gen.kubebuilder.io/version: v0.12.0
+ name: notifications.argocdcommenter.int128.github.io
+spec:
+ group: argocdcommenter.int128.github.io
+ names:
+ kind: Notification
+ listKind: NotificationList
+ plural: notifications
+ singular: notification
+ scope: Namespaced
+ versions:
+ - name: v1
+ schema:
+ openAPIV3Schema:
+ description: Notification is the Schema for the notifications API
+ properties:
+ apiVersion:
+ description: 'APIVersion defines the versioned schema of this representation
+ of an object. Servers should convert recognized schemas to the latest
+ internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
+ type: string
+ kind:
+ description: 'Kind is a string value representing the REST resource this
+ object represents. Servers may infer this from the endpoint the client
+ submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
+ type: string
+ metadata:
+ type: object
+ spec:
+ description: NotificationSpec defines the desired state of Notification
+ type: object
+ status:
+ description: NotificationStatus defines the observed state of Notification
+ properties:
+ commentState:
+ type: string
+ deploymentState:
+ type: string
+ type: object
+ type: object
+ served: true
+ storage: true
+ subresources:
+ status: {} e2e_test/controller/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-manager-role.yaml--- a/tmp/kustomize-action-yVzLyf/e2e_test/controller/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-manager-role.yaml
+++ b/tmp/kustomize-action-yb0e32/e2e_test/controller/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-manager-role.yaml
@@ -3,32 +3,6 @@ kind: ClusterRole
metadata:
name: argocd-commenter-manager-role
rules:
-- apiGroups:
- - argocdcommenter.int128.github.io
- resources:
- - applicationhealths
- verbs:
- - create
- - delete
- - get
- - list
- - patch
- - update
- - watch
-- apiGroups:
- - argocdcommenter.int128.github.io
- resources:
- - applicationhealths/finalizers
- verbs:
- - update
-- apiGroups:
- - argocdcommenter.int128.github.io
- resources:
- - applicationhealths/status
- verbs:
- - get
- - patch
- - update
- apiGroups:
- argoproj.io
resources:
|
This was referenced Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.