fix(ui-pagination): fix Pagination sometimes displaying non li elements in lists, fix key errors too
#1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts in lists, fix key errors too Closes: INSTUI-4422 TEST PLAN: check all examples in inspector, the pagination buttons should all be in lists. There should be no duplicate key warning in the console
matyasf
commented
Jan 7, 2025
| @@ -104,7 +104,7 @@ class Pagination extends Component<PaginationProps> { | |||
| currentPage: 1, | |||
| siblingCount: 1, | |||
| boundaryCount: 1, | |||
| ellipsis: <li style={{all: 'unset'}}>...</li>, | |||
There was a problem hiding this comment.
I think that this was a bug too, that its a li should be an internal part of the component. Also they need the `key' prop so React doesnt throw warnings
matyasf
commented
Jan 7, 2025
| … | ||
| </span> | ||
| <li style={{ all: 'unset' }} key="first" aria-hidden="true"> | ||
| {this.props.ellipsis} |
There was a problem hiding this comment.
now the ellipsis prop works in the legacy code too
|
balzss
approved these changes
Jan 8, 2025
HerrTopi
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: INSTUI-4422
TEST PLAN:
check all examples in inspector, the pagination buttons should all be in lists. There should be no duplicate key warning in the console