update ESLint to v9 and other smaller dependencies #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matyasf
changed the title
|
matyasf
force-pushed
the
update_deps
branch
2 times, most recently
from
78fb56d to
9355a95
Compare
matyasf
changed the title
matyasf
commented
Aug 16, 2024
| @@ -0,0 +1,216 @@ | |||
| /* | |||
There was a problem hiding this comment.
This file was the bulk of the work, please read this file
matyasf
commented
Aug 16, 2024
matyasf
commented
Aug 16, 2024
joyenjoyer
reviewed
Aug 21, 2024
joyenjoyer
reviewed
Aug 21, 2024
| @@ -483,7 +483,7 @@ class SourceCodeEditor extends Component<SourceCodeEditorProps> { | |||
| const { styles } = this.props | |||
|
|
|||
| if (!styles?.theme || !styles.highlightStyle) { | |||
| return | |||
| return undefined | |||
There was a problem hiding this comment.
Why is this needed here?
There was a problem hiding this comment.
ESLint expects that a getter always returns a value. IMO this is a good rule, and its OK if we make such edge cases more explicit
HerrTopi
approved these changes
Aug 22, 2024
Yep, it gets a bit spammy because we have a lot of these. But I think they are useful, we should try to get rid of |
…x warnings in Table ESLint now uses a flat config. our ESLint plugin is not in use yet, it will be added in a future commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: INSTUI-4099, INSTUI-4062, INSTUI-4183
to test: check docs app, check output of
npm run lintfor erroneous lint warnings.The good:
ui-eslint-configpackage is gone :)packages/template-packages had some leftover files that could be deleted.eslintignorefilesvitesttestsThe bad:
eslint-plugin-jsx-a11yis not yet converted to ESLint v9, add it back when its ready Add support for ESLint 9 jsx-eslint/eslint-plugin-jsx-a11y#978eslint-import-resolver-typescriptandeslint-plugin-import-xare not converted either, but these are less useful pluginsOther smaller changes:
isStackedandhoverprop that was always showing in the consolemomentupgrade, turns out the test was bad and moment got better