test(ui-codemods): migrate old Codemods tests #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
git-nandor
force-pushed
the
INSTUI-4126_convert_old_codemods_jest_tests_to_the_new_format
branch
from
7f7594c to
7cf5f6b
Compare
…ook to transform ts files to js Closes: INSTUI-4126 Pirates hook transform is a necessary workaround because vitest does not support importing ts files with `require`.
git-nandor
force-pushed
the
INSTUI-4126_convert_old_codemods_jest_tests_to_the_new_format
branch
from
7cf5f6b to
859bfb0
Compare
matyasf
approved these changes
Aug 9, 2024
| @@ -20,7 +20,7 @@ jobs: | |||
| - name: Set up project. | |||
| run: npm run bootstrap | |||
| - name: Run tests. | |||
| run: USE_REACT_STRICT_MODE=0 npm run test && npm run test:vitest && npm run test:jest && npm run cy:component | |||
| run: USE_REACT_STRICT_MODE=0 npm run test && npm run test:vitest && npm run cy:component | |||
There was a problem hiding this comment.
we still have 1 Jest test suite in the ui package, but that will be converted to vitest next, so its OK that those tests are not running for a few builds.
Comment on lines
+49
to
+52
| addHook(transformCode, { | ||
| exts: ['.ts', '.tsx'], | ||
| ignoreNodeModules: true | ||
| }) |
There was a problem hiding this comment.
We are never unloading this hook. I guess its fine since tests are isolated https://vitest.dev/config/#isolate by default
There was a problem hiding this comment.
Yes, this is not an issue, we are running these tests separately from others.
HerrTopi
approved these changes
Aug 14, 2024
git-nandor
deleted the
INSTUI-4126_convert_old_codemods_jest_tests_to_the_new_format
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: INSTUI-4126