Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(instui-config,ui-modal): modal to accept any children #1618

Merged
merged 1 commit into from
Oct 16, 2024
Merged

feat(instui-config,ui-modal): modal to accept any children #1618

merged 1 commit into from
Oct 16, 2024

Conversation

joyenjoyer
Copy link
Contributor

No description provided.

@joyenjoyer joyenjoyer requested review from HerrTopi and balzss August 2, 2024 13:54
@joyenjoyer joyenjoyer self-assigned this Aug 2, 2024
@joyenjoyer joyenjoyer force-pushed the INSTUI-4094-investigate-if-modal-could-accept-less-strict-children branch from a5187fd to de8db0d Compare August 2, 2024 13:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024 •
edited
Loading

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-16 11:55 UTC

@joyenjoyer joyenjoyer force-pushed the INSTUI-4094-investigate-if-modal-could-accept-less-strict-children branch from 5b49bdd to 824153d Compare August 5, 2024 15:01
@joyenjoyer joyenjoyer changed the title WIP(instui-config,ui-modal): allow simple react nodes as modal children feat(instui-config,ui-modal): modal to accept any children Aug 5, 2024
@joyenjoyer joyenjoyer marked this pull request as ready for review August 5, 2024 15:02
@joyenjoyer joyenjoyer force-pushed the INSTUI-4094-investigate-if-modal-could-accept-less-strict-children branch from 824153d to 532dc3c Compare August 5, 2024 15:02
balzss
balzss reviewed Aug 6, 2024
View reviewed changes
packages/ui-modal/src/Modal/README.md Outdated Show resolved Hide resolved
packages/ui-modal/src/Modal/index.tsx Outdated Show resolved Hide resolved
@joyenjoyer joyenjoyer marked this pull request as draft August 21, 2024 11:33
@joyenjoyer joyenjoyer force-pushed the INSTUI-4094-investigate-if-modal-could-accept-less-strict-children branch from df519a4 to a47b15e Compare August 27, 2024 13:25
@joyenjoyer joyenjoyer requested a review from balzss August 27, 2024 13:27
@joyenjoyer joyenjoyer marked this pull request as ready for review August 27, 2024 13:27
@joyenjoyer joyenjoyer force-pushed the INSTUI-4094-investigate-if-modal-could-accept-less-strict-children branch from a47b15e to 992d562 Compare September 4, 2024 12:41
@joyenjoyer joyenjoyer requested a review from matyasf September 6, 2024 11:48
matyasf
matyasf requested changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments

packages/ui-modal/src/Modal/index.tsx Outdated Show resolved Hide resolved
packages/ui-modal/src/Modal/index.tsx Outdated Show resolved Hide resolved
packages/ui-modal/src/Modal/__new-tests__/Modal.test.tsx Show resolved Hide resolved
packages/ui-modal/src/Modal/README.md Outdated Show resolved Hide resolved
@balzss balzss removed their request for review September 12, 2024 10:10
@balzss balzss requested review from balzss and removed request for balzss September 30, 2024 08:59
@joyenjoyer joyenjoyer force-pushed the INSTUI-4094-investigate-if-modal-could-accept-less-strict-children branch 2 times, most recently from 5d6d9f0 to 8ecccb8 Compare October 11, 2024 12:08
@joyenjoyer joyenjoyer requested review from matyasf and balzss October 11, 2024 12:11
@joyenjoyer joyenjoyer force-pushed the INSTUI-4094-investigate-if-modal-could-accept-less-strict-children branch from 8ecccb8 to dde1d5c Compare October 14, 2024 14:01
matyasf
matyasf requested changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, there are some small docs changes

packages/ui-modal/src/Modal/README.md Show resolved Hide resolved
packages/ui-modal/src/Modal/props.ts Outdated Show resolved Hide resolved
@joyenjoyer joyenjoyer force-pushed the INSTUI-4094-investigate-if-modal-could-accept-less-strict-children branch from dde1d5c to 0f4f620 Compare October 15, 2024 10:03
@joyenjoyer joyenjoyer requested a review from matyasf October 15, 2024 10:05
@joyenjoyer joyenjoyer merged commit 40f8ca2 into master Oct 16, 2024
11 checks passed
@joyenjoyer joyenjoyer deleted the INSTUI-4094-investigate-if-modal-could-accept-less-strict-children branch October 16, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matyasf matyasf matyasf approved these changes

@balzss balzss balzss approved these changes

@HerrTopi HerrTopi Awaiting requested review from HerrTopi

Assignees

@joyenjoyer joyenjoyer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joyenjoyer @matyasf @balzss