test(ui-side-nav-bar): migrate old SideNavBar tests #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL: https://1581--preview-instui.netlify.app |
balzss
reviewed
Jul 15, 2024
| export { SideNavBarItemLocator } | ||
| describe('<SideNavBarItem/>', () => { | ||
| it('should show a tooltip when the nav is minimized ', async () => { | ||
| const onClick = cy.spy() |
There was a problem hiding this comment.
no need to change this but is there a reason this is a spy and not just something like () => {}?
There was a problem hiding this comment.
This is due to the bulk rewriting of the old code stub(). It is entirely equivalent, with no particular reason.
The only advantage is that this way the lint does not throw a warning: warning Unexpected empty method.
balzss
approved these changes
Jul 15, 2024
joyenjoyer
approved these changes
Jul 15, 2024
Closes: INSTUI-4131
git-nandor
force-pushed
the
INSTUI-4131_convert_ui-side-nav-bar_to_the_new_test_format
branch
from
e2ed287 to
3d0ab53
Compare
git-nandor
deleted the
INSTUI-4131_convert_ui-side-nav-bar_to_the_new_test_format
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: INSTUI-4131