Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP(ui-tooltip): add aria-label #1481

Closed
wants to merge 2 commits into from
Closed

WIP(ui-tooltip): add aria-label #1481

wants to merge 2 commits into from

Conversation

HerrTopi
Copy link
Contributor

@HerrTopi HerrTopi commented Apr 4, 2024

Closes: INSTUI-3450

Copy link

github-actions bot commented Apr 5, 2024

Preview URL: https://1481--preview-instui.netlify.app

@HerrTopi HerrTopi requested review from matyasf and balzss April 5, 2024 08:58
@matyasf
Copy link
Collaborator

matyasf commented May 3, 2024

This version is likely not a good solution because its read twice by VoiceOver

@matyasf matyasf self-assigned this Jul 1, 2024
Copy link

PR Preview Action v1.4.7
🚀 Deployed preview to https://instructure.github.io/instructure-ui/pr-preview/pr-1481/
on branch gh-pages at 2024-08-13 13:18 UTC

@matyasf
Copy link
Collaborator

matyasf commented Aug 21, 2024

We are closing this PR because after discussions with the a11y team it came out that we need a different solution to read tooltips in browse mode in NVDA

@matyasf matyasf closed this Aug 21, 2024
@matyasf matyasf deleted the tooltipko branch August 21, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants