Add knowledge form context selection #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerdalert
force-pushed
the
ctx-select
branch
2 times, most recently
from
73a6561 to
5c54128
Compare
|
@nerdalert I will get to this sometime tomorrow. |
nerdalert
force-pushed
the
ctx-select
branch
from
11cad37 to
2ace807
Compare
|
Resolved the rebase issue I had by changing ENV values. Should be good to go meow. |
nerdalert
force-pushed
the
ctx-select
branch
from
2ace807 to
184a44c
Compare
vishnoianil
reviewed
Jan 10, 2025
src/utils/devlog.ts
Outdated
There was a problem hiding this comment.
@nerdalert I don't see devLog used anywhere in this PR, probably remove it?
vishnoianil
reviewed
Jan 10, 2025
| {alertInfo.message} | ||
| </Alert> | ||
| </AlertGroup> | ||
| <Alert variant={alertInfo.type} title={alertInfo.title} actionClose={<AlertActionCloseButton onClose={() => setAlertInfo(undefined)} />}> |
There was a problem hiding this comment.
We can switch the toast alert, so that all the alerts are shown in the top right corner. Here is the example https://github.com/instructlab/ui/blob/main/src/components/Contribute/Skill/Native/index.tsx.
Not required for this PR, but something we can start using for all future alert.
- Adds routes for retrieving files from the local knowledge git - Adds the ability to view the file changes/additions in the native dashboard. - Enables the user to view the knowledge document, highlight the text they want to add to the context field and submit it. The highlighted text will get populated to the context field. - Allows the user to still manually enter context or knowledge file details and handles the state switching when they choose to do so. - Prevents the user from selecting context from a different commit SHA if they have already selected context from another SHA. Signed-off-by: Brent Salisbury <[email protected]>
There is some chatty logging that will be helpful in the short term but should be limited to node dev mode. Signed-off-by: Brent Salisbury <[email protected]>
- Also change the field name to include server side filepath. Signed-off-by: Brent Salisbury <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this probably breaks the container deploy for native with the changes in
src/app/api/native/upload/route.ts. It's not clear to me how to rebase into that if someone could take a look. I think @vishnoianil did that if you don't mind good sir.Not an easy review, there are a ton of different states getting munged together here UploadYaml/AutoFillYaml/DownloadYaml/ViewYaml/ManualKnowledgeFile to name a few. Did my best to juggle all of them but will def have some bugs to fix.
Demo vid:
knowledge-context-v1.mp4