Skip to content

Commit

Permalink
Fix incorrect logic related to --keep_last_checkpoint_only
Browse files Browse the repository at this point in the history
We should not assign a value to this parameter, as it takes no values.

Signed-off-by: Courtney Pacheco <[email protected]>
  • Loading branch information
courtneypacheco committed Jan 16, 2025
1 parent 989e4fb commit 83bd68d
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/instructlab/training/main_ds.py
Original file line number Diff line number Diff line change
Expand Up @@ -707,9 +707,11 @@ def run_training(torch_args: TorchrunArgs, train_args: TrainingArgs) -> None:
f"--max_batch_len={train_args.max_batch_len}",
f"--seed={train_args.random_seed}",
f"--chat-tmpl-path={train_args.chat_tmpl_path}",
f"--keep_last_checkpoint_only={train_args.keep_last_checkpoint_only}",
]

if train_args.keep_last_checkpoint_only:
command.append(f"--keep_last_checkpoint_only")

if train_args.checkpoint_at_epoch:
command.append("--checkpoint_at_epoch")

Expand Down

0 comments on commit 83bd68d

Please sign in to comment.