Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'too many blank lines' error in phoenix/qna.yaml by removing extra blank lines #1377

Open
wants to merge 1 commit into
base: cmb-run-2024-08-26
Choose a base branch
from

Conversation

MichaelClifford
Copy link

Noticed the following error when running instructlab.sdg.generate_data() with the cmb-run-2024-08-26 branch: ERROR]: data/taxonomy/knowledge/science/astronomy/constellations/phoenix/qna.yaml:199:1 too many blank lines (1 > 0) (empty-lines)

This PR removes the extra line from the end of the data/taxonomy/knowledge/science/astronomy/constellations/phoenix/qna.yaml to adderess the error.

@github-actions github-actions bot added triage-needed (Auto labeled) skill is ready to be triaged knowledge (Auto labeled) labels Dec 20, 2024
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers instructlab-bot-triagers instructlab-bot-maintainers oversight-committee]] teams are allowed to run these commands.

@nimbinatus
Copy link
Member

Thank you for the patch! I'm going to put this one on hold for a bit as the Phoenix Constellation knowledge PR is on hold: #1159 (comment). We'll merge it when that PR gets re-merged :)

@nimbinatus nimbinatus added triage-do-not-merge Hold; usually on request due to being used to test something and removed triage-needed (Auto labeled) skill is ready to be triaged labels Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
knowledge (Auto labeled) triage-do-not-merge Hold; usually on request due to being used to test something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants