Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knowledge: writer Thomas De Quincey #1365

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

merobi-hub
Copy link

@merobi-hub merobi-hub commented Dec 12, 2024

Describe the contribution to the taxonomy

  • Knowledge contribution about the writer Thomas De Quincey
  • The model was conflating Thomas De Quincey and another writer, Samuel Taylor Coleridge, resulting in an erroneous answer to the question, "Who is Thomas De Quincey?" For example, "Confessions of an Inquiring Mind" is by Coleridge, but it is credited to De Quincey in the answer.

Input given at the prompt

   Who is Thomas De Quincey?

Response from the original model

  Thomas De Quincey (1785-1844) was an English essayist, novelist, and critic, renowned for his profound exploration of the relationship between memory, imagination, and human experience. He is best known   │
│ for his seminal work "Confessions of an Inquiring Mind" (1826), which delves into the intricacies of De Quincey's own thoughts and recollections, as well as the philosophical underpinnings of his          │
│ intellectual pursuits.                                                                                                                                                                                       │
│                                                                                                                                                                                                              │
│ In "Confessions," De Quincey examines the role of memory in shaping personal identity, reflecting on his past experiences and encounters with various ideas that have captivated his curiosity. The work is  │
│ a rich tapestry of introspection, autobiography, and philosophical inquiry that has left an indelible mark on literary history.                                                                              │
│                                                                                                                                                                                                              │
│ De Quincey's writing style is characterized by its vivid imagery, evocative language, and keen analysis of the human condition. His works often explore themes such as memory, imagination, sensibility, and │
│ individuality, inviting readers to reflect on their own experiences and beliefs.                                                                                                                             │
│                                                                                                                                                                                                              │
│ Beyond his literary contributions, De Quincey was a prominent figure in the Victorian intellectual scene. He corresponded with many luminaries of his age, including Charles Darwin, John Keats, and George  │
│ Eliot. His thoughtful and engaging correspondence provides valuable insights into the cultural and intellectual climate of the time, as well as the complex interplay between literature, science, and       │
│ philosophy.                                                                                                                                                                                                  │
│                                                                                                                                                                                                              │
│ In summary, Thomas De Quincey was a remarkable figure in English literature, celebrated for his explorations of memory, imagination, and human experience. His groundbreaking work continues to resonate     │
│ with readers today, offering a unique perspective on the intricate relationship between the past, the present, and the future. 

Response from the fine-tuned model

  Thomas De Quincey (1814-1869) was a British essayist, journalist, and social critic, renowned for his profound insight into the Victorian era's moral issues. He was an advocate of free will and            │
│ individualism, often exploring these themes in his works. De Quincey is particularly famous for his 1859 work "Confessions of an English Opium Eater," which delves into his personal struggles with         │
│ addiction to opium.                                                                                                                                                                                          │
│                                                                                                                                                                                                              │
│ In this memoir, he provides a vivid and honest account of his experiences, shattering the social stigma surrounding drug use and contributing significantly to the Victorian literary landscape. De          │
│ Quincey's writing is characterized by its evocative imagery and emotional intensity, making him a prominent figure in 19th-century literature.   

Contribution checklist

  • The contribution was tested with ilab generate
  • No errors or warnings were produced by ilab generate
  • All commits are signed off (DCO)
  • The qna.yaml file contains at least 5 seed_examples
  • The qna.yaml file was linted and prettified (yaml-validator can do both)
  • An attribution.txt file in the same folder as the qna.yaml file
  • Content does not include PII or otherwise sensitive or confidential information
  • Content does not include anything documented in the project's Avoid these Topics guidelines

@github-actions github-actions bot added triage-needed (Auto labeled) skill is ready to be triaged knowledge (Auto labeled) labels Dec 12, 2024
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers instructlab-bot-triagers instructlab-bot-maintainers oversight-committee]] teams are allowed to run these commands.

@merobi-hub
Copy link
Author

merobi-hub commented Dec 12, 2024

ilab generate printed these warnings:

WARNING 2024-12-12 09:46:58,501 instructlab.data.generate_data:77: Disabling SDG batching - unsupported with llama.cpp serving
/Users/michael/.pyenv/versions/3.11.11/lib/python3.11/site-packages/llama_cpp/llama.py:1054: RuntimeWarning: Detected duplicate leading "<s>" in prompt, this will likely reduce response quality, consider removing it...
  warnings.warn(

Can you tell me if this is a problem? I took a chance given that it seems possible they don't reflect an issue with the changes here, but I would be happy to see if I can resolve these issues myself. Please let me know. Thanks!

@merobi-hub merobi-hub changed the title Writer Thomas De Quincey knowledge contribution Knowledge: writer Thomas De Quincey Dec 12, 2024
@jjasghar
Copy link
Member

We need to wait for the new version of the cmb shows up in the environment. /cc @vishnoianil can you update us on when that will be ready?

@jjasghar jjasghar added triage-requested-changes skill has been reviewed; changes requested from contributor and removed triage-needed (Auto labeled) skill is ready to be triaged labels Dec 19, 2024
Copy link

github-actions bot commented Jan 4, 2025

This pull request has been automatically marked as stale because it has not had activity within 15 days. It will be automatically closed if no further activity occurs within the next 31 days.

@github-actions github-actions bot added the stale stale-bot has marked you as stale label Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
knowledge (Auto labeled) stale stale-bot has marked you as stale triage-requested-changes skill has been reviewed; changes requested from contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants