Remove legacy unprocessed foundational_skills folder #1363
Conversation
The foundational_skills folder is no longer processed evidenced by the taxonomy folders var at https://github.com/instructlab/schema/blob/82f2d790a7854858a9d112c0840b532617e44116/src/instructlab/schema/taxonomy.py#L30. Therefore: we should remove this folder in the community taxonomy to provide clarity to users where to place skill content. Signed-off-by: Tyler Lisowski <[email protected]>
relyt0925
force-pushed
the
remove-legacy-folder
branch
from
e1455e9 to
e44024b
Compare
|
Thank you for finding this, but there is a lot more to discuss before we can remove this. Being the Community model builds aren't still running at 100% changing/removing things for the foreseeable future I'm hesitant to support. Get everything "green" again, before cleaning up things. |
jjasghar
added
the
triage-uncertain
|
@jjasghar are you saying then it will be adjusted back to add foundational skills right now the community reference doesn’t accurately reflect the code processing it |
|
There’s an issue that folks are looking at this as an initial reference for building taxonomies (their private taxonomies) and the structure isn’t accurate for the latest community versions of Instructlab leading to confusion |
|
This pull request has been automatically marked as stale because it has not had activity within 15 days. It will be automatically closed if no further activity occurs within the next 31 days. |
|
Not stale |
|
On hold until we get folks back online after the holidays |
The foundational_skills folder is no longer processed evidenced by the taxonomy folders var at https://github.com/instructlab/schema/blob/82f2d790a7854858a9d112c0840b532617e44116/src/instructlab/schema/taxonomy.py#L30. Therefore: we should remove this folder in the community taxonomy to provide clarity to users where to place skill content.