-
Notifications
You must be signed in to change notification settings - Fork 980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Knowledge: Fifa's laws of the game #1350
base: main
Are you sure you want to change the base?
Knowledge: Fifa's laws of the game #1350
Conversation
Signed-off-by: Jeff Duncan <[email protected]>
Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉 I support the following commands:
Note Results or Errors of these commands will be posted as a pull request check in the Checks section below Note Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers instructlab-bot-triagers instructlab-bot-maintainers oversight-committee]] teams are allowed to run these commands. |
Please fix the DCO, and I'm surprised this isn't already in the model(s). We'll have to run this against the backend to see if there is a value add here. |
I'm really not sure. I was trying to learn instruct lab so I just came up with something somewhat random. The laws of the game for soccer which are really just the rules of the game, are all over the Internet so I'm guessing it's in the model already?
If I can make a suggestion, you may want to add some examples of things that you want to add that might improve the model. I also don't know what the dco is.
Jeff A Duncan
919-757-6245
…________________________________
From: JJ Asghar ***@***.***>
Sent: Sunday, December 1, 2024 12:13:39 PM
To: instructlab/taxonomy ***@***.***>
Cc: gtyellow ***@***.***>; Author ***@***.***>
Subject: Re: [instructlab/taxonomy] Knowledge: Fifa's laws of the game (PR #1350)
Please fix the DCO, and I'm surprised this isn't already in the model(s). We'll have to run this against the backend to see if there is a value add here.
—
Reply to this email directly, view it on GitHub<#1350 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AXYTMK2RFMJ25AWS2DPVASD2DM7UHAVCNFSM6AAAAABSKBY3UOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJQGA3DAMZTHE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
@instructlab-bot precheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please fix the DCO.
These are the international rules for soccer. They are called the laws of the | ||
game. | ||
seed_examples: | ||
- context: This is the rules of the shape and dimensions of a field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The context
should be a specific section from the referenced document that you declare at the bottom of this yaml
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created_by: gtyellow | ||
version: 3 | ||
domain: Sports | ||
document_outline: >- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The document_outline
should be a "one liner" descriptive overview of the submission. This should be concise yet descriptive enough for an LLM to build context.
This pull request has been automatically marked as stale because it has not had activity within 15 days. It will be automatically closed if no further activity occurs within the next 31 days. |
questions_and_answers: | ||
- question: What is a handball? | ||
answer: >- | ||
If a player who isn't the goalies touches the ball from the tips of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suspected typo: "goalies" -> "goalie"
An interesting soccer-related question might be "Please explain the offside rule to me in simple terms" :) |
This pull request has been automatically marked as stale because it has not had activity within 15 days. It will be automatically closed if no further activity occurs within the next 31 days. |
These are the international rules for soccer. They are called the laws of the game.