Removed wikilink from the knowledge example #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
|
@jjasghar we actually do need to be keeping the wikilinks in the yamls for now because the context in the yaml file must match what is in the markdown file!! |
|
Closed per the triage meeting. This will be needed to be done at a later date. |
|
Should we redo this one now after the changes from juliadenham/Summit_knowledge#1 ? @juliadenham |
bjhargrave
requested changes
Aug 20, 2024
- Removed wikilink code - Added an array for the document section Signed-off-by: JJ Asghar <[email protected]>
jjasghar
force-pushed
the
jjasghar/update_example_18
branch
from
5767114 to
6507fda
Compare
bjhargrave
approved these changes
Aug 20, 2024
jjasghar
added a commit
that referenced
this pull request
Sep 3, 2024
This reverts commit f876908. Signed-off-by: JJ Asghar <[email protected]>
juliadenham
pushed a commit
that referenced
this pull request
Sep 3, 2024
Reverts #1266 Signed-off-by: JJ Asghar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @juliadenham